Switch to c2-chacha crate for ChaCha20-IETF #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves encryption throughput by around 60% over standard, and around 10% when compiled with the AVX2 flag, because c2-chacha uses AVX2 when available.
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 49.69% 50.72% +1.03%
==========================================
Files 23 23
Lines 1793 1790 -3
==========================================
+ Hits 891 908 +17
+ Misses 902 882 -20
Continue to review full report at Codecov.
|
tarcieri
reviewed
Mar 14, 2020
| @@ -21,7 +21,8 @@ age-core = { version = "0.3.1", path = "../age-core" } | |||
| base64 = "0.11" | |||
|
|
|||
| # - ChaCha20-Poly1305 from RFC 7539 | |||
| chacha20poly1305 = "0.3" | |||
| c2-chacha = "0.2" | |||
| chacha20poly1305 = "0.4" | |||
There was a problem hiding this comment.
FYI, you should be able to do:
chacha20poly1305 = { version = "0.4", default = false }...which will eliminate the chacha20 dependency, which is redundant if you're using c2-chacha
/cc @cryptocorrosion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves encryption throughput by around 60% over standard, and around 10% when compiled with the AVX2 flag, because c2-chacha uses AVX2 when available.
Part of #57.