Remove SyncFusion #751
Merged
Remove SyncFusion #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrycox
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things
Firstly and foremost, completely strips out all references to SyncFusion. StoryCAD in the past has relied on SyncFusion as WinUI has had Comboboxes that were for the most part broken. I am glad to say WinUI has finally rectified the multitude of problems with the combobox, as such while we are extremly greatful to syncfusion for all the help they have provided us, it is no longer worth our time dealing with updating and maintaining Syncfusion. One of the largest problems with WinUI Comboboxes was them being cut off with the window if the combox extended past the bounds of the window; this has been fixed.
Secondly while we are on the topic of ComboBoxes, this PR fixes the handful of them scattered throughout StoryCAD that aren't styled correctly. This occured because a few Comboboxes of StoryCAD inherit the combobox style but not the CornerRadius value, this led these few comboboxes having square edges breaking visual consistency. As a stopgap measure I've added CornerRadius=4 to the three custom comboboxes. I say this is a stop gap measure as I personally don't think these warrant being classes at all as all they do is set the itemsource to some filter of StoryModel.StoryElements and this could be done much more gracefully by referencing ShellVM or perhaps even adding a reference to StoryModel.GetModel() within the relevant page so its bindable as two out of three clases are only used within a single XAML page, the last is used in three.
Updated box look (look at the StoryProblem Box)
