-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Node 14 from engines field #353
Conversation
I guess in theory the runner works fine in Node 14 but the test framework requires Node 16 so no way to actually test for that? |
c988ac2
to
cbcb8e3
Compare
cbcb8e3
to
9d9a3df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #353 +/- ##
=======================================
Coverage 80.64% 80.64%
=======================================
Files 12 12
Lines 217 217
Branches 56 56
=======================================
Hits 175 175
Misses 42 42 ☔ View full report in Codecov by Sentry. |
Hey there! Since Node 14 is out of the picture, I just removed it. I don't think it's a breaking change because the test-runner uses Storybook 7 and it doesn't support Node 14, so I don't think this ever worked. I changed it to test just with Node 16 and 18 on the basic action and node 20 on the extended action. Thanks a lot for this contribution! |
🚀 PR was released in |
This is intended to help debug and catch regressions across Node.js versions, as well as making future major upgrades easier.
.nvmrc
16
[14.x, 18.x, 20.x]
(oldest supported, LTS, newest supported)Version
Published prerelease version:
v0.15.2-next.3
Changelog
🐛 Bug Fix
Authors: 3