Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up prototype #16

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Clean up prototype #16

merged 2 commits into from
Jan 3, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 3, 2022 •
edited by github-actions bot
Loading

What I did

  • Add CI tests, jest config
  • Rename transformTestingLib => transformJsdom
  • Remove support for .tests annotation (we only support play function now)
  • Update tests for playwright/JSDOM

How to test

CI passes

📦 Published PR as canary version: 0.0.1-canary.16.dc0b1a5.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@yannbf
Copy link
Member

yannbf commented Jan 3, 2022

Looks great!

@shilman shilman merged commit dc0b1a5 into feat/prototype Jan 3, 2022
@shilman shilman deleted the feat/clean-up-prototype branch January 3, 2022 14:05
@github-actions github-actions bot mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @yannbf