Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMPROVE the build-storybooks script #9569

Merged
merged 2 commits into from
Jan 21, 2020
Merged

IMPROVE the build-storybooks script #9569

merged 2 commits into from
Jan 21, 2020

Conversation

ndelangen
Copy link
Member

No description provided.

@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jan 20, 2020
@ndelangen ndelangen added this to the 6.0.0 milestone Jan 20, 2020
@ndelangen ndelangen requested a review from igor-dv as a code owner January 20, 2020 23:53
@ndelangen ndelangen self-assigned this Jan 20, 2020
@vercel
Copy link

vercel bot commented Jan 20, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@ndelangen
Copy link
Member Author

ndelangen commented Jan 21, 2020 •
edited
Loading

@gabrielcsapo @aromanarguello @dbendaou @gossi @rwjblue Would either of you be able to understand why the storybook for ember isn't building?

shilman
shilman requested changes Jan 21, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

scripts/build-storybooks.js Outdated Show resolved Hide resolved
@ndelangen
Copy link
Member Author

The now.sh failure is exactly the point of this PR, it IS already failing on next, but we're not seeing it because the error isn't caught in NodeJS 10

@ndelangen
Copy link
Member Author

I think I'll temporarily disable the ember example to be build to see if this is the last broken example.

@ndelangen ndelangen mentioned this pull request Jan 21, 2020
Closed
@ndelangen ndelangen force-pushed the fix/build-storybook-script branch from f0c915c to 31ddf96 Compare January 21, 2020 10:05
shilman
shilman approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndelangen ndelangen merged commit fed325e into next Jan 21, 2020
@ndelangen ndelangen deleted the fix/build-storybook-script branch January 21, 2020 10:50
@dependabot-preview dependabot-preview bot mentioned this pull request Feb 24, 2020
Closed
@mcaj-admin mcaj-admin mentioned this pull request Feb 22, 2021
Open
@Watemlifts Watemlifts mentioned this pull request Feb 22, 2021
Closed
@mcaj-admin mcaj-admin mentioned this pull request Feb 23, 2021
Open
@dudusae dudusae mentioned this pull request Feb 23, 2021
Open
@Watemlifts Watemlifts mentioned this pull request Feb 23, 2021
Closed
@dudusae dudusae mentioned this pull request Feb 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @shilman