Skip to content

Core: Module format load accept loader function #7518

Merged
shilman merged 6 commits into
nextfrom
7512-load-files
Jul 22, 2019
Merged

Core: Module format load accept loader function #7518
shilman merged 6 commits into
nextfrom
7512-load-files

Conversation

@shilman
Copy link
Copy Markdown
Member

@shilman shilman commented Jul 22, 2019 •
edited
Loading

Issue: #7512

What I did

  • load accepts req, [req], or loaderFn
  • bugfix for deleting stories
  • update examples, including cra15 as designated project for back-compat

Follow up

How to test

cd examples/official-storybook
yarn storybook

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 22, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-7512-load-files.storybook.now.sh

@shilman shilman added this to the 5.2.0 milestone Jul 22, 2019
tmeasday
tmeasday approved these changes Jul 22, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we want to ensure load is only called once somehow?

Comment thread examples/official-storybook/config.js Outdated
Comment thread lib/core/src/client/preview/start.js Outdated
// Find all the imports
// Remove old imports that are unused
// Add any new imports
// Set previousExports to currentExports
Copy link
Copy Markdown
Member

@tmeasday tmeasday Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these

shilman added a commit that referenced this pull request Jul 22, 2019
@shilman
Update load docs per #7518 and fix typos
e946b49
@shilman @tmeasday
Update examples/official-storybook/config.js
c75337e 
Co-Authored-By: Tom Coleman <tom@thesnail.org>
@vercel vercel Bot temporarily deployed to staging July 22, 2019 06:27 Inactive
@shilman shilman merged commit 5ba41e2 into next Jul 22, 2019
@shilman shilman deleted the 7512-load-files branch July 22, 2019 09:07
This was referenced Jul 22, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmeasday tmeasday tmeasday approved these changes

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@alterx alterx Awaiting requested review from alterx

@danielduan danielduan Awaiting requested review from danielduan

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

@usulpro usulpro Awaiting requested review from usulpro

Assignees

No one assigned

Labels

core feature request

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@shilman @tmeasday