Skip to content

CLI: update sb init to module format for HTML/Polymer #7503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shilman merged 2 commits into from
Jul 20, 2019
Merged

CLI: update sb init to module format for HTML/Polymer #7503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa662da
CLI templates: HTML => module format
shilman Jul 20, 2019
218934c
CLI templates: Polymer => module format
shilman Jul 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions lib/cli/generators/EMBER/template/.storybook/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
import { configure } from '@storybook/ember';
import { load } from '@storybook/ember';

// automatically import all files ending in *.stories.js
const req = require.context('../stories', true, /\.stories\.js$/);
function loadStories() {
req.keys().forEach(filename => req(filename));
}

configure(loadStories, module);
load(require.context('../stories', true, /\.stories\.js$/), module);
Comment thread
shilman marked this conversation as resolved.
9 changes: 2 additions & 7 deletions lib/cli/generators/HTML/template/.storybook/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
import { configure } from '@storybook/html';
import { load } from '@storybook/html';

// automatically import all files ending in *.stories.js
const req = require.context('../stories', true, /\.stories\.js$/);
function loadStories() {
req.keys().forEach(filename => req(filename));
}

configure(loadStories, module);
load(require.context('../stories', true, /\.stories\.js$/), module);
23 changes: 13 additions & 10 deletions lib/cli/generators/HTML/template/stories/index.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
import { document, console } from 'global';
import { storiesOf } from '@storybook/html';

storiesOf('Demo', module)
.add('heading', () => '<h1>Hello World</h1>')
.add('button', () => {
const button = document.createElement('button');
button.type = 'button';
button.innerText = 'Hello Button';
button.addEventListener('click', e => console.log(e));
return button;
});
export default {
title: 'Demo',
};

export const heading = () => '<h1>Hello World</h1>';

export const button = () => {
const btn = document.createElement('button');
btn.type = 'button';
btn.innerText = 'Hello Button';
btn.addEventListener('click', e => console.log(e));
return btn;
};
9 changes: 2 additions & 7 deletions lib/cli/generators/POLYMER/template/.storybook/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
import { configure } from '@storybook/polymer';
import { load } from '@storybook/polymer';

// automatically import all files ending in *.stories.js
const req = require.context('../src/stories', true, /\.stories\.js$/);
function loadStories() {
req.keys().forEach(filename => req(filename));
}

configure(loadStories, module);
load(require.context('../src/stories', true, /\.stories\.js$/), module);