-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy button for individual story #6719
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-thollander-6708-add-copy-button.storybook.now.sh |
13734e5
to
cd34ea2
Compare
cd34ea2
to
a580bb6
Compare
@thollander thanks for adding this! the snapshot tests are currently failing due to the change -- would you mind updating the snapshots with |
a580bb6
to
9d777ec
Compare
@shilman, sure ! thanks for the tip. |
@domyen WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, would like @domyen design eye on this.
Looks good, small suggestion would be good to have some visual feedback that link is copied. |
9d777ec
to
d99cc33
Compare
d99cc33
to
91978fe
Compare
91978fe
to
74d6227
Compare
lgtm |
Sneaking this into 5.1 |
Thanks for the contribution @thollander ! |
No problem @ndelangen ! |
@thollander @domyen can we instead make the "Open canvas" control a link instead of a button? Then we would get all the benefits of native HTML links, which include: – Ability to copy the href from context menu |
That sounds like a good improvement indeed! This would merge both use cases into a single piece of UI. |
Issue: #6708
What I did
Add copy button to get individual story link.
How to test
There should be a copy button on all stories.