You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "contexts" line in the README's Addons section links to https://github.com/storybookjs/storybook/tree/next/code/addons/toolbars, which returns a 404 (that folder no longer exists on next).
PR title must be in the format of "Area: Summary", With both Area and Summary starting with a capital letter
Good examples:
- "Docs: Describe Canvas Doc Block"
- "Svelte: Support Svelte v4"
Bad examples:
- "add new api docs"
- "fix: Svelte 4 support"
- "Vue: improve docs"
🚫
This PR needs an approving review from a Storybook Core or Developer Experience team member before it can be merged. No approvals found.
🤖 I am the Storybook contribution review bot. This message was posted automatically.
Review phase: Runtime verification (stage 3 of 3)
We are trying a three-stage automated review: architecture, code quality, and runtime verification. This message states which stages ran and which were skipped. Messages are posted automatically, and a human maintainer makes the final decision. Please tell us whether the feedback and evidence are useful.
Thanks for fixing this, @Vinay-Hiver! The old code/addons/toolbars link has pointed to a folder that no longer exists, so this is a welcome cleanup.
Result at b7f2641: verified, no changes requested.
Runtime verification (stage 3 of 3): passed. The old link returns HTTP 404, and code/addons/toolbars does not exist on the base commit. The new link returns HTTP 200 and opens the "Toolbars & globals" docs page, which covers the feature that replaced the toolbars addon. The diff changes only that one URL in README.md.
Architecture (stage 1) and code quality (stage 2): skipped. This is a one-line documentation change, so these stages do not apply.
A human maintainer makes the final decision on this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agent-scan:humanci:normalRun our default set of CI jobs (choose this for most PRs).documentationqa:skipPull Requests that do not need any QA. (e.g. documentation)review:verifiedThree-step review passed: architecture, code quality, runtime verificationsev:S4Low priority. Wait for community PRs.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The "contexts" line in the README's Addons section links to
https://github.com/storybookjs/storybook/tree/next/code/addons/toolbars, which returns a 404 (that folder no longer exists onnext).I pointed the link at the current docs page instead: https://storybook.js.org/docs/essentials/toolbars-and-globals (the other links in that section still work).
Docs-only change, one line in
README.md.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Open the README on this branch and click "toolbars" in the line that starts "If you're using contexts": it opens the Toolbars & globals docs page.
Documentation