Skip to content

Svelte: Remove deprecated parameters.component path - #36813

Merged
valentinpalkovic merged 1 commit into
nextfrom
norbert/sb-2012-remove-deprecated-svelte-parameterscomponent-path
Oct 20, 2026
Merged

valentinpalkovic merged 1 commit into
nextfrom
norbert/sb-2012-remove-deprecated-svelte-parameterscomponent-path

Conversation

@ndelangen

Copy link
Copy Markdown
Member

Closes #

Linear: SB-2012

What I did

Remove the leftover Svelte docs source-decorator deprecation for parameters.component. Since Storybook 7 that path only warned; wrapper stories already generate source from context.component (the meta component). Document the removal in MIGRATION.md.

Out of scope (owned by Svelte Docgen / Agent-ready Svelte): legacyTemplate and other Svelte CSF legacy removals.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

generateSvelteSource coverage in sourceDecorator.test.ts is unchanged. The removed branch was a console deprecation only and had no dedicated assertion.

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Inspect the diff for code/renderers/svelte/src/docs/sourceDecorator.ts. Confirm the deprecate(...) call and parameters.component check are gone, and that @wrapper stories still assign component = ctxComponent.
  2. Run git grep -n "parameters.component is deprecated" -- code. Expect no matches.
  3. Optionally open a Svelte sandbox Docs page for a story that uses a @wrapper render component and a meta component. Confirm the Code panel still shows the meta component, not the wrapper.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Declare whether manual QA will be needed for this PR during the next release, through qa:needed or qa:skip

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary Release - 🚫 Not run

This PR does not have a canary release associated.

In-repo PRs: add the ci:canary label. Later pushes republish while the label remains.

Fork PRs: the label does nothing (a later push must not auto-publish). A maintainer publishes from this repository with Run workflow and the pr input. branch and sha are optional; if more than one is set, they must be the same commit. The fork author does not need to do anything.

Storybook 11 drops the leftover deprecation warning in the Svelte source
decorator. Wrapper stories already generate source from context.component.
@ndelangen ndelangen added BREAKING CHANGE ci:normal Run our default set of CI jobs (choose this for most PRs). qa:skip Pull Requests that do not need any QA. (e.g. documentation) labels Oct 15, 2026
@ndelangen ndelangen self-assigned this Oct 15, 2026
@valentinpalkovic
valentinpalkovic marked this pull request as ready for review October 19, 2026 09:26
@github-actions

Copy link
Copy Markdown
Contributor
Fails
🚫 This PR needs an approving review from a Storybook Core or Developer Experience team member before it can be merged. No approvals found.

Generated by 🚫 dangerJS against 6ad5291

@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Removes the Svelte source decorator's remaining parameters.component warning.

  • Svelte wrapper stories use the meta component without a deprecated parameter warning.

Reviews (1) · Last reviewed commit: "Svelte: Remove deprecated parameters.com..." · Reviewed by Greptile

@valentinpalkovic
valentinpalkovic merged commit 71d7519 into next Oct 20, 2026
156 of 162 checks passed
@valentinpalkovic
valentinpalkovic deleted the norbert/sb-2012-remove-deprecated-svelte-parameterscomponent-path branch October 20, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BREAKING CHANGE ci:normal Run our default set of CI jobs (choose this for most PRs). qa:skip Pull Requests that do not need any QA. (e.g. documentation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants