Repository navigation
Svelte: Remove deprecated parameters.component path - #36813
Merged
valentinpalkovic merged 1 commit intoOct 20, 2026
Merged
valentinpalkovic merged 1 commit into
valentinpalkovic merged 1 commit into
Conversation
Storybook 11 drops the leftover deprecation warning in the Svelte source decorator. Wrapper stories already generate source from context.component.
valentinpalkovic
marked this pull request as ready for review
October 19, 2026 09:26
Contributor
Contributor
[Medium impact] This PR appears safe to merge. SummaryRemoves the Svelte source decorator's remaining
Reviews (1) · Last reviewed commit: "Svelte: Remove deprecated parameters.com..." · Reviewed by Greptile |
valentinpalkovic
approved these changes
Oct 20, 2026
valentinpalkovic
deleted the
norbert/sb-2012-remove-deprecated-svelte-parameterscomponent-path
branch
October 20, 2026 10:17
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Linear: SB-2012
What I did
Remove the leftover Svelte docs source-decorator deprecation for
parameters.component. Since Storybook 7 that path only warned; wrapper stories already generate source fromcontext.component(the metacomponent). Document the removal inMIGRATION.md.Out of scope (owned by Svelte Docgen / Agent-ready Svelte):
legacyTemplateand other Svelte CSF legacy removals.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
generateSvelteSourcecoverage insourceDecorator.test.tsis unchanged. The removed branch was a console deprecation only and had no dedicated assertion.Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
code/renderers/svelte/src/docs/sourceDecorator.ts. Confirm thedeprecate(...)call andparameters.componentcheck are gone, and that@wrapperstories still assigncomponent = ctxComponent.git grep -n "parameters.component is deprecated" -- code. Expect no matches.@wrapperrender component and a metacomponent. Confirm the Code panel still shows the meta component, not the wrapper.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary Release - 🚫 Not run
This PR does not have a canary release associated.
In-repo PRs: add the
ci:canarylabel. Later pushes republish while the label remains.Fork PRs: the label does nothing (a later push must not auto-publish). A maintainer publishes from this repository with Run workflow and the
prinput.branchandshaare optional; if more than one is set, they must be the same commit. The fork author does not need to do anything.