Skip to content

CLI: Warn when the preview still imports the Custom Elements Manifest #36777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huang-julien merged 5 commits into from
Oct 14, 2026
Merged

CLI: Warn when the preview still imports the Custom Elements Manifest #36777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5684696
CLI: Warn when the preview still imports the Custom Elements Manifest
huang-julien Oct 14, 2026
1d9bd14
fix(cli): also catch manifest imports that reach the setter indirectly
huang-julien Oct 14, 2026
8b0bdf5
Merge branch 'next' into julien/wc-runtime-manifest-import-warning
huang-julien Oct 14, 2026
e677a2f
chore: wording
huang-julien Oct 14, 2026
b8bbf69
Merge branch 'julien/wc-runtime-manifest-import-warning' of https://g…
huang-julien Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions code/lib/cli-storybook/src/automigrate/fixes/angular-vite-remove-compodoc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,15 +412,15 @@ const manualRemovalHint = (previewConfigPath: string, reason: string): void =>
);

const removePreviewWiring = (preview: ConfigFile, previewConfigPath: string): void => {
const reason = removeTopLevelCall(preview._ast.program, {
const result = removeTopLevelCall(preview._ast.program, {
callee: SET_COMPODOC_JSON,
calleeSources: new Set([ADDON_DOCS_ANGULAR]),
});
if (reason) {
if (!result.removed) {
manualRemovalHint(
previewConfigPath,
countReferences(preview._ast.program, SET_COMPODOC_JSON) > 0
? reason
? result.reason
: `no ${SET_COMPODOC_JSON} call is visible here, only a documentation.json import`
);
return;
Expand Down
Loading
Loading