Skip to content

Docs: Clarify Angular provider decorators - #36362

Merged
valentinpalkovic merged 2 commits into
storybookjs:nextfrom
erenbati:docs/angular-provider-guidance-22237
Oct 12, 2026
Merged

valentinpalkovic merged 2 commits into
storybookjs:nextfrom
erenbati:docs/angular-provider-guidance-22237

Conversation

@erenbati

Copy link
Copy Markdown
Contributor

Closes #22237

What I did

Clarified the difference between Angular's applicationConfig and moduleMetadata decorators in both Angular framework guides.

The new note explains that:

  • applicationConfig configures providers in Angular's application bootstrap environment, including providers passed to bootstrapApplication.
  • moduleMetadata configures declarations, imports, and providers needed by the story's Angular template.
  • The decorators configure different scopes and can be used together when a story needs both.

This guidance is added to both the Angular Webpack and Angular Vite documentation.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This is a documentation-only change and does not modify runtime behavior.

To review it:

  1. Open the Angular Webpack framework documentation and confirm the info callout appears between the applicationConfig example and the Angular dependencies section.
  2. Open the Angular Vite framework documentation and confirm the same guidance appears in the equivalent location.
  3. Confirm the wording distinguishes application-bootstrap providers from story template declarations/imports/providers without changing the existing examples.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update MIGRATION.MD

AI disclosure

ChatGPT assisted with repository research, collision checking, and drafting this documentation clarification. I reviewed and approved the final two-file diff and can respond to review feedback.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 420722fb-1556-4b2c-a9f5-98a23a8c5811

📥 Commits

Reviewing files that changed from the base of the PR and between 6643f31 and e60ac4e.

📒 Files selected for processing (2)
  • docs/get-started/frameworks/angular-vite.mdx
  • docs/get-started/frameworks/angular.mdx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


Walkthrough

The Angular and Angular-Vite guides now explain the scopes of applicationConfig and moduleMetadata, including that both decorators can be used together.

Changes

Angular provider documentation

Layer / File(s) Summary
Provider scope guidance
docs/get-started/frameworks/angular.mdx, docs/get-started/frameworks/angular-vite.mdx
Added callouts that define applicationConfig for bootstrap-level providers and moduleMetadata for story-template declarations, imports, and providers. The callouts state that both decorators can be combined.

Priority: ⬇️ Low

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@storybook-contribution-review storybook-contribution-review Bot added documentation angular qa:skip Pull Requests that do not need any QA. (e.g. documentation) sev:S4 Low priority. Wait for community PRs. review:3-verification Stage 2 passed: awaiting stage 3 proof-of-work verification review:verified Three-step review passed: architecture, code quality, runtime verification and removed review:3-verification Stage 2 passed: awaiting stage 3 proof-of-work verification labels Sep 23, 2026
@storybook-contribution-review

Copy link
Copy Markdown

🤖 I am the Storybook contribution review bot; a human maintainer approved this message before it was posted.
Review phase: Final verdict - runtime verification complete (architecture and code quality stages skipped for a trivial diff)

We are trying out something new: a three-stage automated review - architecture, then code quality, then runtime verification - that runs on a PR before a human maintainer looks at it closely. A maintainer still reads this and still makes the call; the aim is that by the time they do, the reachability and evidence work is already done. Tell us how it lands for you, that feedback is genuinely useful to us right now.

Thank you for making the provider scopes concrete in both Angular guides. Runtime verification used one token from applicationConfig and one token from moduleMetadata in the same rendered component.

The direct renderer probes passed 12 of 12 tests for Angular Webpack and 12 of 12 for Angular Vite. The related runtime suites passed 33 of 33 tests for each framework. yarn docs:check and git diff --check HEAD^ HEAD also passed, and both guides use the correct framework imports with matching guidance.

The full sandbox could not install from the local harness registry, but that shared environment failure did not affect the direct Angular renderer evidence. This is a documentation-only change, so the architecture and code-quality stages were skipped.

The verification passed at head e60ac4e880e03172bcd4f828311e51111d1a8833. I am marking this contribution verified and ready for a human maintainer's final merge decision.

@github-actions github-actions Bot added the Stale label Oct 6, 2026
@valentinpalkovic valentinpalkovic added the ci:docs Run the CI jobs for documentation checks only. label Oct 6, 2026
@valentinpalkovic valentinpalkovic self-assigned this Oct 12, 2026
@valentinpalkovic
valentinpalkovic merged commit 872577a into storybookjs:next Oct 12, 2026
44 of 50 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 12, 2026
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-scan:human angular ci:docs Run the CI jobs for documentation checks only. documentation needs triage qa:skip Pull Requests that do not need any QA. (e.g. documentation) review:verified Three-step review passed: architecture, code quality, runtime verification sev:S4 Low priority. Wait for community PRs.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Documentation]: angular: missing documentation for bootstrapApplication and moduleMetadata

2 participants