Repository navigation
Docs: Explain Vite build option handling - #36361
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe Vite builder documentation now states that Storybook inherits only Vite’s ChangesVite build option documentation
Priority: ⬇️ Low Severity of issue fixed: Medium ✨ Finishing Touches 💡 1
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thank you for documenting this easy-to-miss Vite boundary. Runtime verification supplied The focused base-and-head run passed 14 of 14 tests across two files. This is a documentation-only change, so the architecture and code-quality stages were skipped. The verification passed at head |
|
@erenbati thanks for taking the time to put together this pull request and helping us improve the documentation. Appreciate it 🙏 ! I've checked and it looks good on my end. Merging |
Closes #28189
What I did
Added an info callout to the Vite builder documentation explaining that Storybook does not inherit most
buildoptions fromvite.config.js|ts.The docs now clarify that:
build.targetis carried over from the user's Vite config.build.chunkSizeWarningLimitorbuild.commonjsOptions, should be configured throughviteFinalin.storybook/main.js|ts.This matches the current builder implementation, which removes the user's
buildobject before merging the rest of the Vite config and only restoresbuild.target.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This is a documentation-only change and does not modify runtime behavior.
To review it:
viteFinalexample.code/builders/builder-vite/src/vite-config.ts.Documentation
MIGRATION.MDAI disclosure
ChatGPT assisted with repository research, collision checking, and drafting this documentation change. I reviewed and approved the final one-file diff and can respond to review feedback.