Skip to content

Docs: Correct viewport dimensions for desktop and nexus5x - #36240

Merged
kylegach merged 2 commits into
storybookjs:nextfrom
kawarimidoll:patch-2
Oct 6, 2026
Merged

kylegach merged 2 commits into
storybookjs:nextfrom
kawarimidoll:patch-2

Conversation

@kawarimidoll

Copy link
Copy Markdown
Contributor

Closes #

What I did

I found incorrect resolution values in the document and corrected them.

  • desktop height and width were transposed
  • nexus5x height was different

Here are sources:

desktop: {
name: 'Desktop',
styles: {
height: '1024px',
width: '1280px',
},
type: 'desktop',
},

nexus5x: {
name: 'Nexus 5X',
styles: {
height: '660px',
width: '412px',
},
type: 'mobile',
},

AI disclosure: I noticed the transposed resolution on the desktop myself, but Claude Code found the error in the nexus5x height. I made the changes myself!

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

No manual test is necessary, this PR just changes numbers in Markdown table.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Declare whether manual QA will be needed for this PR during the next release, through qa:needed or qa:skip

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary Release - 🚫 Not run

This PR does not have a canary release associated.

In-repo PRs: add the ci:canary label. Later pushes republish while the label remains.

Fork PRs: the label does nothing (a later push must not auto-publish). A maintainer publishes from this repository with Run workflow and the pr input. branch and sha are optional; if more than one is set, they must be the same commit. The fork author does not need to do anything.

Fixed resolutions:
- desktop height and width were transposed
- nexus5x height was different
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 76b46448-5185-425a-8b1f-d3ecb9ce48b5

📥 Commits

Reviewing files that changed from the base of the PR and between 0675cff and d95004e.

📒 Files selected for processing (1)
  • docs/essentials/viewport.mdx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

Changes

Viewport documentation

Layer / File(s) Summary
Update viewport dimensions
docs/essentials/viewport.mdx
The minimal desktop viewport changes to 1280 × 1024. The nexus5x viewport height changes to 660px.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to d9500

This updates desktop and Nexus 5X viewport dimensions in documentation only, with no remaining merge-readiness risk.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@storybook-contribution-review storybook-contribution-review Bot added addon: viewport documentation qa:skip Pull Requests that do not need any QA. (e.g. documentation) sev:S4 Low priority. Wait for community PRs. labels Sep 9, 2026
@kawarimidoll kawarimidoll changed the title docs: correct viewport dimensions for desktop and nexus5x Docs: Correct viewport dimensions for desktop and nexus5x Sep 10, 2026
@github-actions github-actions Bot added the Stale label Oct 1, 2026

@kylegach kylegach left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches, @kawarimidoll! And congratulations on your first contribution! 🥳

@kylegach kylegach added patch:yes Bugfix & documentation PR that need to be picked to main branch ci:docs Run the CI jobs for documentation checks only. and removed addon: viewport labels Oct 6, 2026
@kylegach kylegach self-assigned this Oct 6, 2026
@kylegach
kylegach merged commit 48dfcc6 into storybookjs:next Oct 6, 2026
31 of 38 checks passed
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-scan:human ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch qa:skip Pull Requests that do not need any QA. (e.g. documentation) sev:S4 Low priority. Wait for community PRs. Stale

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants