Repository navigation
Build: Run yarn dedupe after sandbox install - #35793
Conversation
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
736aeae to
41b9351
Compare
Research follow-upThe earlier act-compat diagnosis was wrong for this CI failure. CircleCI job 1858884 shows nested React under The branch has been force-pushed to the resolutions fix instead. #34708 / act-compat remains a separate issue if we still want that fix later. |
|
Updated: dropped the resolutions approach. The PR now only runs |
After #35790 keeps the before-storybook lockfile, the post-init tree can leave nested copies of shared packages (e.g. react under addon-docs). Run `yarn dedupe` for every sandbox after the final install so Yarn can collapse those before vitest and other tasks run. Co-authored-by: Cursor <cursoragent@cursor.com>
15ea946 to
3bc142b
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe sandbox task now runs ChangesSandbox dependency flow
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
Comment |
Closes #
What I did
react-latest--vite---typescript---vitestwent red onnextafter #35790 kept the publishedbefore-storybooklockfile. The failing log shows nested React under@storybook/addon-docs(Invalid hook call), not act-environment warnings.This PR tries the least invasive fix: after every sandbox’s final
yarn install, runyarn dedupeso Yarn can collapse nested copies before vitest/e2e/etc.No new
resolutionsentries. Applies to all sandboxes, not only React.If CI still fails, we can fall back to pinning
react/react-domresolutions (as nextjs sandboxes already do).Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Covered by sandbox vitest jobs under
ci:daily/ci:merged, especiallyreact-latest--vite---typescript---vitest.Manual testing
yarn task sandbox --template react-vite/default-ts --no-link --debugfind node_modules -path '*/react/package.json' | sort@storybook/addon-docs)yarn task vitest-integration --template react-vite/default-ts --no-link -s vitest-integrationDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.