Repository navigation
Build: Add 7d minimum release age gate to the repository's Yarn config - #35763
Merged
Merged
Conversation
Freshly published versions are not resolvable for 7 days, so a compromised release has time to be detected and pulled before it can enter the tree. Installs from the committed lockfile are unaffected. Co-authored-by: Cursor <cursoragent@cursor.com>
JReinhold
approved these changes
Aug 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a repository-wide Yarn safeguard (npmMinimalAgeGate) to reduce exposure to newly published npm packages (a common supply-chain attack window) by requiring package versions to be at least 7 days old before Yarn will select them during dependency adds/updates.
Changes:
- Configure Yarn’s
npmMinimalAgeGateto 7 days (10080 minutes) at the repo level.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| nodeLinker: node-modules | ||
|
|
||
| npmMinimalAgeGate: 10080 |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughChangesYarn package policy
Possibly related PRs
Comment |
2 tasks done
Merged
15 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Yarn can refuse to install package versions that were published very recently.
Recent npm supply-chain attacks have followed the same shape: an attacker publishes a malicious patch release over a widely used package, and it is caught and pulled within hours.
Anything that installs during that short window gets the payload; anything that waits does not.
Our own repository had no such rule configured, so an attack landing in that window could reach a contributor or CI machine through any dependency update.
This sets that window to 7 days for the repository.
The rule only applies when a dependency is added or updated.
Installing from the committed lockfile is unaffected, so day-to-day work and CI behave exactly as before.
The practical effect is that adding or bumping a dependency will not pick up a release younger than a week.
This matches the rule applied to generated sandboxes in #34852.
Manual testing
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Made with Cursor