Repository navigation
Docs: Fix broken web-components snippets in loaders documentation - #35368
jonniebigodes merged 2 commits into
Conversation
The web-components examples in the loaders documentation were calling `TodoItem` as a function without ever importing or defining it — a copy-paste error from the React/Solid versions. Replaced with the correct `html` tagged template literal from `lit`, consistent with all other web-components snippets in the repository. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated Web Components code examples in docs/_snippets/loader-story.md to render ChangesLoader story documentation update
Estimated code review effort: 1 (Trivial) | ~5 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi! This PR is failing the label check since I don't have permission to add labels myself. Could a maintainer please add documentation, ci:docs, and qa:skip? |
jonniebigodes
left a comment
There was a problem hiding this comment.
@coderanac thanks for taking the time to put together this pull request and helping us improve the documentation by catching this small issue with the snippets. We appreciate it 🙏 !
I've checked and all is good on my end.
This will get merged shortly.
Hope you have a great day.
Stay safe
Docs: Fix broken web-components snippets in loaders documentation
What I did
The web-components examples in the loaders documentation were calling
TodoItemas a function without ever importing or defining it — acopy-paste error from the React/Solid versions.
File:
docs/_snippets/loader-story.mdBefore:
After:
All 4 affected snippets (JS CSF 3, TS CSF 3, JS CSF Next, TS CSF Next) received the same fix. The pattern follows the
htmltagged template literal fromlitalready used in all other web-components snippets in the repository.Checklist for Contributors
Testing
Manual testing
N/A - docs-only change
Documentation
Summary by CodeRabbit