Repository navigation
UI: Hide onboarding menu with feature flag - #35299
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughAdds a new ChangesOnboarding guide feature flag
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches📝 Generate docstrings
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/api/main-config/main-config-features.mdx`:
- Around line 240-246: Update the `menuOnboardingChecklist` docs to describe its
full behavior, not just the menu link. In the `main-config-features` entry for
`menuOnboardingChecklist`, mention that this boolean controls both the
onboarding menu entry and the dev-only `Guide` settings tab. Keep the existing
identifiers and default/type info, but expand the description so the public
config contract matches the behavior exposed by the feature.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 939c12fa-91fa-4095-a823-972088e650cb
📒 Files selected for processing (6)
code/core/src/core-server/presets/common-preset.tscode/core/src/manager/components/sidebar/Sidebar.stories.tsxcode/core/src/manager/container/Menu.tsxcode/core/src/manager/settings/index.tsxcode/core/src/types/modules/core-common.tsdocs/api/main-config/main-config-features.mdx
Contributor
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 72 | 72 | 0 |
| Self size | 21.88 MB | 21.68 MB | 🎉 -200 KB 🎉 |
| Dependency size | 36.44 MB | 36.44 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 204 | 204 | 0 |
| Self size | 821 KB | 821 KB | 🎉 -34 B 🎉 |
| Dependency size | 91.26 MB | 91.06 MB | 🎉 -200 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 197 | 197 | 0 |
| Self size | 32 KB | 32 KB | 0 B |
| Dependency size | 89.74 MB | 89.54 MB | 🎉 -200 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 73 | 73 | 0 |
| Self size | 1.09 MB | 1.09 MB | 0 B |
| Dependency size | 58.32 MB | 58.12 MB | 🎉 -200 KB 🎉 |
| Bundle Size Analyzer | node | node |
ndelangen
approved these changes
Jun 29, 2026
yannbf
approved these changes
Jun 29, 2026
2 tasks done
This was referenced Jul 10, 2026
Merged
This was referenced Jul 13, 2026
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35274
What I did
Added a feature flag to hide the onboarding guide in the menu
menuOnboardingChecklist, similar tosidebarOnboardingChecklist, so users can choose how they want to expose it.I created a new flag to avoid disrupting users who currently only want to hide the main sidebar widget.
Checklist for Contributors
Testing
Not testable via stories as the Sidebar stories emulate the menu.
Manual testing
menuOnboardingChecklistfalse to yourcode/.storybook/main.tsfeaturesDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
New Features
Documentation