Repository navigation
Conversation
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sidnioulz
reviewed
Jun 26, 2026
Contributor
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 72 | 72 | 0 |
| Self size | 21.88 MB | 21.68 MB | 🎉 -201 KB 🎉 |
| Dependency size | 36.44 MB | 36.44 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 102 | 109 | 🚨 +7 🚨 |
| Self size | 36 KB | 36 KB | 🎉 -24 B 🎉 |
| Dependency size | 42.99 MB | 44.15 MB | 🚨 +1.16 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 204 | 204 | 0 |
| Self size | 821 KB | 821 KB | 🚨 +1 B 🚨 |
| Dependency size | 91.26 MB | 91.06 MB | 🎉 -201 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 197 | 197 | 0 |
| Self size | 32 KB | 32 KB | 0 B |
| Dependency size | 89.74 MB | 89.54 MB | 🎉 -201 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 73 | 73 | 0 |
| Self size | 1.09 MB | 1.09 MB | 🎉 -66 B 🎉 |
| Dependency size | 58.32 MB | 58.12 MB | 🎉 -201 KB 🎉 |
| Bundle Size Analyzer | node | node |
Sidnioulz
approved these changes
Jun 29, 2026
2 tasks done
This was referenced Jul 10, 2026
Merged
This was referenced Jul 13, 2026
Merged
Open
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35289
The
TRIGGER_TEST_RUN_REQUESThandler inpreset.tssendsTRIGGER_RUNto the store and then subscribes to completion events. If the run finishes quickly — which happens for focused or small story sets via@storybook/addon-mcp— theTEST_RUN_COMPLETEDevent can fire before the subscription is in place. The response channel never emitsTRIGGER_TEST_RUN_RESPONSE, and the MCP caller hangs until it times out.The fix registers the
store.subscribecall beforestore.send, so any completion event that fires synchronously or near-synchronously is captured. The logic inside the subscriber is unchanged.Summary by CodeRabbit
Manual testing
See instructions on #35289. Use canary
0.0.0-pr-35291-sha-a08be029