Repository navigation
Docs: Add security warning for --host 0.0.0.0 in CLI options - #35241
Conversation
Co-authored-by: ghengeveld <321738+ghengeveld@users.noreply.github.com>
--host 0.0.0.0 in CLI options
📝 WalkthroughWalkthroughThe ChangesCLI Options Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Comment |
jonniebigodes
left a comment
There was a problem hiding this comment.
@ghengeveld thanks for taking the time to make this pull request and adjusting the docs with this important caveat. Appreciate it 🙏 . I've checked it and left a small item for you to look into when you can.
Approving to unblock you.
Co-authored-by: jonniebigodes <joaocontadesenvolvimento@gmail.com>
|
@copilot fix markdown table formatting |
Co-authored-by: ghengeveld <321738+ghengeveld@users.noreply.github.com>
Done in 7f8e978. Removed trailing spaces from all description column cells throughout the file so the table formatting is consistent — no row is wider than the others. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/api/cli-options.mdx`:
- Line 177: The CLI example in the `--package-manager` row is missing a space
between `[addon]` and `--package-manager` flag, making the command `storybook
remove [addon]--package-manager pnpm` invalid. Add a space before
`--package-manager` so the example reads `storybook remove [addon]
--package-manager pnpm` to make it a valid copy-pasteable command.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 05747507-1d44-405e-8210-70b41d41cbe5
📒 Files selected for processing (1)
docs/api/cli-options.mdx
The
--hostCLI flag docs gave no indication that binding to0.0.0.0exposes Storybook to all network interfaces, or thatcore.allowedHostsexists to mitigate this. The runtime warning inbuild-dev.tsalready covers this at runtime, but users reading the docs had no way to know.Changes
docs/api/cli-options.mdx: Expanded the--hostflag description to note that0.0.0.0binds to all interfaces and links tocore.allowedHostsfor restricting access.Manual testing
None needed.
Summary by CodeRabbit
storybook dev --host [string]documentation to clarify that0.0.0.0binds to all network interfaces and added a reference to host-access security configuration.