Repository navigation
Conversation
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (20)
💤 Files with no reviewable changes (16)
📝 WalkthroughWalkthroughThe PR removes the Changesaddon-review removal and CollectionKind type cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
Comment |
17b4543 to
e398ca3
Compare
fcd4d44 to
ee374f5
Compare
e398ca3 to
c565551
Compare
ee374f5 to
bdb76fb
Compare
With the review manager UI now living in core (PR4c), the addon was an empty husk. Delete it and remove every reference so review has exactly one home. - delete code/addons/review/ entirely - drop @storybook/addon-review from code/package.json, .storybook/main.ts (addons + stories glob), core/src/common/versions.ts, scripts/build/ entry-configs.ts - repoint scripts/display-review.ts badge surface to the core story location - regenerate yarn.lock git grep for @storybook/addon-review / addons/review is now clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
`ReviewCollection.kind` / `CollectionKind` was never part of the canonical
`display-review` producer schema in `@storybook/addon-mcp` and is read by no
rendering code — it only existed in the type, its re-exports, and story/test
fixtures. Remove it so the core contract matches the producer exactly
(`title` / `description` / `collections{title,rationale,storyIds}` / `changedFiles`,
plus the server-side `createdAt` / `stale`).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
c565551 to
90cfdb1
Compare
bdb76fb to
11e75f6
Compare
9582eba
into
yann/agentic-review-mcp-integration
What I did
Deletes the now-empty
@storybook/addon-reviewpackage. This is the final PR (PR5)of the telescoping stack that dissolves the review addon into core; it sits on top
of PR4c (
review-core/04c-mount-internalization/ #35232), which already moved theentire manager UI into
core/src/manager/components/reviewand mounted it from themanager App. After PR4c the addon was an empty husk (its
./presetwent in PR4b, its./managerUI in PR4c), so this PR is pure deletion + reference cleanup.code/addons/review/entirely (huskindex.ts/manager.tsx, buildconfig, README, project.json, tsconfig).
@storybook/addon-reviewreference (git grepis now clean):code/package.jsonworkspace dependencycode/.storybook/main.ts— theaddonsentry and theaddons/review/srcstories glob (the stories now live under the
core/src/managerglob)code/core/src/common/versions.ts(generated list — hand-edited to match)scripts/build/entry-configs.ts— thereviewConfigbuild entryscripts/display-review.ts— repointed the badge-surface story path to the newcore location (
core/src/manager/components/review/ReviewToolbarHeader.stories.tsx)yarn.lockregenerated viayarn installDecisions I made / open questions
MIGRATION.mdentry / nodocumentationlabel. Review and the addon areunreleased (the feature lives on
nextvia Core: Introduce Agentic Review feature #34837; the addon only ever publishedunder the
canarydist-tag). There is no released API to migrate from, so amigration note would be misleading. The whole stack lands before any stable release.
versions.tsis a generated file; its generator can't run standalone here, soI hand-edited it to drop the
@storybook/addon-reviewline (matching the deletion).How to test
git grep -n "@storybook/addon-review\|addons/review\|storybook/addon-review"→no results (outside historical changelogs).
cd code && yarn storybook:ui:buildsucceeds;cd code && yarn storybook:ui→review works end-to-end exactly as on PR4c (push a review, summary + toolbar +
prev/next, dismiss restores chrome), now with the addon package gone.
yarn nx run-many -t checkis clean (no dangling import of the deleted package).Checklist
Maintainer:
maintenance·ci:normal·qa:needed. Base:review-core/04c-mount-internalization.🤖 Generated with Claude Code
Summary by CodeRabbit
Refactor
Chores