Skip to content

Agentic Review [5]: Remove the @storybook/addon-review package - #35233

Merged
yannbf merged 2 commits into
yann/agentic-review-mcp-integrationfrom
review-core/05-remove-addon-shell
Jun 22, 2026
Merged

yannbf merged 2 commits into
yann/agentic-review-mcp-integrationfrom
review-core/05-remove-addon-shell

Conversation

@yannbf

@yannbf yannbf commented Jun 19, 2026 •

Copy link
Copy Markdown
Member

What I did

Deletes the now-empty @storybook/addon-review package. This is the final PR (PR5)
of the telescoping stack that dissolves the review addon into core; it sits on top
of PR4c (review-core/04c-mount-internalization / #35232), which already moved the
entire manager UI into core/src/manager/components/review and mounted it from the
manager App. After PR4c the addon was an empty husk (its ./preset went in PR4b, its
./manager UI in PR4c), so this PR is pure deletion + reference cleanup.

  • Deleted code/addons/review/ entirely (husk index.ts/manager.tsx, build
    config, README, project.json, tsconfig).
  • Removed every @storybook/addon-review reference (git grep is now clean):
    • code/package.json workspace dependency
    • code/.storybook/main.ts — the addons entry and the addons/review/src
      stories glob (the stories now live under the core/src/manager glob)
    • code/core/src/common/versions.ts (generated list — hand-edited to match)
    • scripts/build/entry-configs.ts — the reviewConfig build entry
    • scripts/display-review.ts — repointed the badge-surface story path to the new
      core location (core/src/manager/components/review/ReviewToolbarHeader.stories.tsx)
    • yarn.lock regenerated via yarn install

Decisions I made / open questions

🤖 AI note (Claude Code), authored autonomously for @yannbf — review before merge.

  • No MIGRATION.md entry / no documentation label. Review and the addon are
    unreleased (the feature lives on next via Core: Introduce Agentic Review feature #34837; the addon only ever published
    under the canary dist-tag). There is no released API to migrate from, so a
    migration note would be misleading. The whole stack lands before any stable release.
  • versions.ts is a generated file; its generator can't run standalone here, so
    I hand-edited it to drop the @storybook/addon-review line (matching the deletion).

How to test

  1. git grep -n "@storybook/addon-review\|addons/review\|storybook/addon-review" →
    no results (outside historical changelogs).
  2. cd code && yarn storybook:ui:build succeeds; cd code && yarn storybook:ui →
    review works end-to-end exactly as on PR4c (push a review, summary + toolbar +
    prev/next, dismiss restores chrome), now with the addon package gone.
  3. yarn nx run-many -t check is clean (no dangling import of the deleted package).

Checklist

  • Unit tests (no behavior change; coverage moved with the code in PR4c)
  • Manual testing: see "How to test" — verify review still works with the addon deleted.

Maintainer: maintenance · ci:normal · qa:needed. Base: review-core/04c-mount-internalization.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor

    • Simplified review collection structure by removing collection kind metadata.
    • Consolidated review addon components and functionality into core codebase.
  • Chores

    • Removed the standalone review addon package.
    • Updated package dependencies and Storybook configuration.
    • Cleaned up addon-specific build and configuration files.

@yannbf yannbf added maintenance User-facing maintenance tasks ci:normal Run our default set of CI jobs (choose this for most PRs). qa:needed Pull Requests that will need manual QA prior to release. labels Jun 19, 2026
@yannbf yannbf changed the title maintenance(review): remove the @storybook/addon-review package PR5: Remove the @storybook/addon-review package Jun 19, 2026
@storybook-app-bot

storybook-app-bot Bot commented Jun 19, 2026 •

Copy link
Copy Markdown
Contributor

Package Benchmarks

Commit: 11e75f6, ran on 19 June 2026 at 16:52:40 UTC

No significant changes detected, all good. 👏

@yannbf
yannbf marked this pull request as ready for review June 19, 2026 13:27
@coderabbitai

coderabbitai Bot commented Jun 19, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 36498e9e-edb1-48d3-94d7-a8bc89decad8

📥 Commits

Reviewing files that changed from the base of the PR and between 90cfdb1 and 11e75f6.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (20)
  • code/.storybook/main.ts
  • code/addons/review/README.md
  • code/addons/review/build-config.ts
  • code/addons/review/manager.js
  • code/addons/review/package.json
  • code/addons/review/project.json
  • code/addons/review/src/index.ts
  • code/addons/review/src/manager.tsx
  • code/addons/review/tsconfig.json
  • code/addons/review/vitest.config.ts
  • code/core/src/common/versions.ts
  • code/core/src/core-server/server-channel/review-channel.test.ts
  • code/core/src/manager/components/review/review-state.ts
  • code/core/src/manager/components/review/screens/SummaryScreen.stories.tsx
  • code/core/src/shared/review/index.ts
  • code/core/src/shared/review/review-state.ts
  • code/core/src/types/modules/review.ts
  • code/package.json
  • scripts/build/entry-configs.ts
  • scripts/display-review.ts
💤 Files with no reviewable changes (16)
  • code/core/src/shared/review/review-state.ts
  • code/addons/review/tsconfig.json
  • code/package.json
  • code/addons/review/vitest.config.ts
  • code/addons/review/package.json
  • code/core/src/common/versions.ts
  • code/core/src/core-server/server-channel/review-channel.test.ts
  • code/addons/review/project.json
  • code/addons/review/README.md
  • code/addons/review/src/manager.tsx
  • code/addons/review/manager.js
  • scripts/build/entry-configs.ts
  • code/addons/review/src/index.ts
  • code/addons/review/build-config.ts
  • code/.storybook/main.ts
  • code/core/src/manager/components/review/screens/SummaryScreen.stories.tsx

📝 Walkthrough

Walkthrough

The PR removes the CollectionKind type alias and the optional kind field from the ReviewCollection interface, propagating that removal through all re-export layers. In parallel, the @storybook/addon-review package is gutted: all source files are emptied, and all build registrations, package metadata, and Storybook config references are deleted.

Changes

addon-review removal and CollectionKind type cleanup

Layer / File(s) Summary
Remove CollectionKind from ReviewCollection contract
code/core/src/shared/review/review-state.ts, code/core/src/shared/review/index.ts, code/core/src/types/modules/review.ts, code/core/src/manager/components/review/review-state.ts
ReviewCollection interface drops the optional kind field and the CollectionKind type alias; all re-export layers are narrowed to expose only ReviewCollection and ReviewState.
Update test fixtures and stories to drop kind field
code/addons/review/src/index.ts, code/core/src/core-server/server-channel/review-channel.test.ts, code/core/src/manager/components/review/screens/SummaryScreen.stories.tsx
Removes kind from the sampleReview channel test fixture, from all collection entries across full, largeCascade, atomicChange, and manyCollections story fixtures, and strips the CollectionKind re-export from the addon index.
Remove @storybook/addon-review package from build and registry
scripts/build/entry-configs.ts, code/.storybook/main.ts, code/core/src/common/versions.ts, code/package.json, scripts/display-review.ts, code/addons/review/...
Removes the addon from build entry configs, Storybook main config stories and addons arrays, versions.ts, and package.json dependencies; empties all addon-review source and config files; redirects the BADGE_REVIEW_SURFACES story import path to the core manager location.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • storybookjs/storybook#34874: Directly related — that PR adds CollectionKind and the optional kind field to ReviewCollection, which this PR reverses by removing them from the core review state contract.
  • storybookjs/storybook#35110: Directly related — introduces CollectionKind and kind?: CollectionKind in addon review state types, which this PR removes; both touch the same review state/type contract.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@yannbf yannbf changed the title PR5: Remove the @storybook/addon-review package Agentic Review [5]: Remove the @storybook/addon-review package Jun 19, 2026
@yannbf
yannbf force-pushed the review-core/04c-mount-internalization branch from 17b4543 to e398ca3 Compare June 19, 2026 14:50
@yannbf
yannbf force-pushed the review-core/05-remove-addon-shell branch from fcd4d44 to ee374f5 Compare June 19, 2026 14:50
@yannbf
yannbf force-pushed the review-core/04c-mount-internalization branch from e398ca3 to c565551 Compare June 19, 2026 15:14
@yannbf
yannbf force-pushed the review-core/05-remove-addon-shell branch from ee374f5 to bdb76fb Compare June 19, 2026 15:14
yannbf and others added 2 commits June 19, 2026 18:33
With the review manager UI now living in core (PR4c), the addon was an empty
husk. Delete it and remove every reference so review has exactly one home.

- delete code/addons/review/ entirely
- drop @storybook/addon-review from code/package.json, .storybook/main.ts
  (addons + stories glob), core/src/common/versions.ts, scripts/build/
  entry-configs.ts
- repoint scripts/display-review.ts badge surface to the core story location
- regenerate yarn.lock

git grep for @storybook/addon-review / addons/review is now clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
`ReviewCollection.kind` / `CollectionKind` was never part of the canonical
`display-review` producer schema in `@storybook/addon-mcp` and is read by no
rendering code — it only existed in the type, its re-exports, and story/test
fixtures. Remove it so the core contract matches the producer exactly
(`title` / `description` / `collections{title,rationale,storyIds}` / `changedFiles`,
plus the server-side `createdAt` / `stale`).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@yannbf
yannbf force-pushed the review-core/04c-mount-internalization branch from c565551 to 90cfdb1 Compare June 19, 2026 16:37
@yannbf
yannbf force-pushed the review-core/05-remove-addon-shell branch from bdb76fb to 11e75f6 Compare June 19, 2026 16:37
Base automatically changed from review-core/04c-mount-internalization to yann/agentic-review-mcp-integration June 22, 2026 09:38
@yannbf
yannbf merged commit 9582eba into yann/agentic-review-mcp-integration Jun 22, 2026
144 of 148 checks passed
@yannbf
yannbf deleted the review-core/05-remove-addon-shell branch June 22, 2026 09:40
@Sidnioulz Sidnioulz added qa:success Pull Requests that were successfully QA'ed by the release team. and removed qa:needed Pull Requests that will need manual QA prior to release. labels Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal Run our default set of CI jobs (choose this for most PRs). maintenance User-facing maintenance tasks qa:success Pull Requests that were successfully QA'ed by the release team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants