Agentic Review [4a]: Dead-code cleanup, filters-ref dedup, and review-mode ADR

[yannbf]

What I did

The original PR4 (mount internalization + internal state module + server-cache move) is large and behavior-bearing. Research showed it's safest to split it. This is PR4a — the low-risk, behavior-preserving cleanups carved out so they land independently green and shrink the surface the heavy follow-up has to move. PR4a of the stack, telescoping on PR3 (#35220).

• Phantom collapseNavOnOpen removed. It was emitted on every DISPLAY_REVIEW payload and asserted in preset.test.ts, but no consumer reads it. Removed from the emit and the test assertions.
• Dead code deleted: the unused AIBadge component; the unused storyPreviewUrl export; and isReviewStoryRoute/isReviewModeRoute (test-only, no production consumer) plus their tests.
• useReviewFiltersRef extracted. The identical "snapshot the current sidebar filters into a ref" block was copy-pasted in ReviewProvider, useReviewNavigationInterceptor, and useReviewShortcuts. Now one hook.

Deferred to PR4b (the heavy slice)

Mount internalization (render the review layer + toolbar header directly in core's Layout/Preview/Toolbar, delete persistentRender + TOOLBAR_HEADER, revert render: FC|null → FC), the internal manager-api review state module (retire the standalone store + module-global summaryOverlaySuppressed), the server-cache move into core-server, and the M8 prev/next dedup. Those are cross-package, API-breaking changes that deserve their own review.

Stack position

Base: review-core/03-route-and-rename (PR3, #35220).

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

For a maintainer:

1. Run a sandbox or cd code && yarn storybook:ui, push a review, and confirm the full flow is unchanged: summary ↔ story navigation, prev/next, keyboard shortcuts (←/→/↑/↓/esc), the collection picker, dismiss, and the "New" badge.
2. This PR removes only dead code and de-duplicates a hook, so there should be no observable behavior change.

Documentation

• Add or update documentation reflecting your changes
• MIGRATION — N/A (unreleased)

Checklist for Maintainers

• ci:normal
• qa:needed
• One changelog label: maintenance

---

🤖 AI note (Claude Code), not written by Yann:

Why PR4 was split. A research pass found the full PR4 moves ~22 files from addons/review/ into core and changes ~12-15 core files (manager render tree, the public addon-API type surface, and core-server preset composition) at once — too much to land green in one reviewable step. I split it: PR4a (this PR) is pure cleanup with zero cross-package surface change; PR4b will do the mount internalization + state module + server move + API deletion. Each slice telescopes, and PR4a strictly shrinks what PR4b must move.

Decision: isReviewStoryRoute/isReviewModeRoute had tests but no production consumer (the route→mode coupling they implied is exactly what review mode must not do — review mode is interaction-driven, never inferred from the route). I deleted them with their tests rather than keep test-only code alive.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Fixed review state payload handling to preserve navigation behavior settings.

• Refactor

  • Improved review mode filter state management for better consistency across navigation and shortcuts.
  • Removed unused routing helper functions.
  • Removed AI Badge component.

• Chores

  • Cleaned up import statements and removed unnecessary code.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3ccee200-276d-4443-a399-52a3d185a8d9

📥 Commits

Reviewing files that changed from the base of the PR and between 659695f and a117062.

📒 Files selected for processing (1)

• code/core/src/manager/components/sidebar/review-mode.ts

✅ Files skipped from review due to trivial changes (1)

• code/core/src/manager/components/sidebar/review-mode.ts

---

📝 Walkthrough

Walkthrough

The PR extracts a new useReviewFiltersRef hook that centralizes sidebar filter state management, replacing duplicated useRef/useStorybookState wiring in ReviewProvider, useReviewNavigationInterceptor, and useReviewShortcuts. It also removes the exported storyPreviewUrl, isReviewStoryRoute, and isReviewModeRoute helpers, drops the forced collapseNavOnOpen: true override in the PUSH_REVIEW handler, and deletes the AIBadge styled component.

Changes

Review mode hook extraction and cleanup

Layer / File(s)	Summary
New useReviewFiltersRef hook code/addons/review/src/useReviewFiltersRef.ts	Introduces a hook that reads included/excluded status and tag filters from useStorybookState on every render and returns a stable MutableRefObject<ReviewModeFilters>, so callbacks can access up-to-date filter state without rebinding.
Hook consumers migrated to useReviewFiltersRef code/addons/review/src/ReviewProvider.tsx, code/addons/review/src/useReviewNavigationInterceptor.ts, code/addons/review/src/useReviewShortcuts.ts	All three files replace their local useRef<ReviewModeFilters> + useStorybookState filter construction with a call to useReviewFiltersRef(); redundant imports (useStorybookState, ReviewModeFilters, useRef) are removed and dependency arrays are updated to include filtersRef.
Remove routing helpers, collapseNavOnOpen override, and comment cleanup code/addons/review/src/review-navigation.ts, code/addons/review/src/review-navigation.test.ts, code/addons/review/src/preset.ts, code/addons/review/src/preset.test.ts, code/core/src/manager/components/sidebar/review-mode.ts	Deletes storyPreviewUrl, isReviewStoryRoute, and isReviewModeRoute from review-navigation.ts; isReviewReturnSearch now uses isReviewSummaryPath and path.startsWith directly. The PUSH_REVIEW handler emits DISPLAY_REVIEW with the cached state directly instead of spreading collapseNavOnOpen: true. Tests are updated to match the removed helpers and changed payload. Import order and a comment in review-mode.ts are cleaned up.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• storybookjs/storybook#35110: Directly related — touches the same review-navigation.ts routing helpers (isReviewStoryRoute/isReviewModeRoute) and filter state wiring in ReviewProvider and review navigation hooks that this PR removes or refactors.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[storybook-app-bot]

Package Benchmarks

^{Commit: a117062, ran on 19 June 2026 at 19:51:06 UTC}

No significant changes detected, all good. 👏

[yannbf]

PR Looks good, we should remove this though