Manager: Fix race condition in experimental_setFilter#35194
Merged
Conversation
If two calls to this are made close together (for example, two addons initialising a filter in `addons.register`), only one may take effect.
mrginglymus
added
bug
ci:normal
Contributor
|
@mrginglymus oh no. Some tests are failing, possibly mock implems that need to be adjusted. Could you please have a look? |
Contributor
Author
|
@Sidnioulz done! |
mrginglymus
force-pushed
the
bill/set-filter-race-condition
branch
from
834fda3 to
6129424
Compare
github-project-automation
Bot
moved this from In Progress
to Done
in Core Team Projects
Contributor
|
Thanks @mrginglymus! Looking forward to merging your other PR too :) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
If two calls to this are made close together (for example, two addons initialising a filter in
addons.register), only one may take effect.Switching to the callback form of
setStatefixes this.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
I don't think manual testing is necessary.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>