Docs: Clarify addon catalog indexing#35161
Conversation
📝 WalkthroughWalkthroughThis PR updates integration-catalog addon documentation to replace generic timing expectations with actionable troubleshooting steps. The changes instruct users to verify published metadata using npm commands and provide detailed diagnostic information when reporting catalog listing issues. ChangesAddon Catalog Troubleshooting Guidance
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jonniebigodes
left a comment
There was a problem hiding this comment.
@krish-mittal1 thanks for taking the time to put together this pull request and helping us improve the documentation. We appreciate it. I left some items for you to look into when you're able.
Let me know once you've gone through them and I'll gladly take another look into this pull request and get it merged.
Hope you have a great day.
Stay safe
fd4daf3 to
042abca
Compare
|
Thanks for the review. I reverted the extra wording changes and kept this focused on the timing/troubleshooting section. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/addons/integration-catalog.mdx (1)
94-96: 💤 Low valueConsider making the placeholder more explicit.
The placeholder
your-addon-package-namecould be clearer with angle brackets or other formatting to indicate it must be replaced.📝 Suggested improvement
-npm view your-addon-package-name --json +npm view <your-addon-package-name> --json🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/addons/integration-catalog.mdx` around lines 94 - 96, The placeholder text `your-addon-package-name` in the npm view shell command is not visually distinct enough to clearly indicate it must be replaced. Wrap the placeholder with angle brackets (change `your-addon-package-name` to `<your-addon-package-name>`) to make it explicit that this is a placeholder value that users need to substitute with their actual addon package name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/addons/integration-catalog.mdx`:
- Line 98: Update the GitHub repository link in the issue reporting instructions
to point to the correct repository for addon catalog issues. Change the link
from storybookjs/web (which is for the documentation website itself) to
storybookjs/storybook (where the addon catalog service is managed).
Additionally, consider enhancing the instructions by providing a concrete
example of the npm package URL format, such as
`https://www.npmjs.com/package/storybook-addon-example`, to clarify expectations
for users reporting catalog issues.
---
Nitpick comments:
In `@docs/addons/integration-catalog.mdx`:
- Around line 94-96: The placeholder text `your-addon-package-name` in the npm
view shell command is not visually distinct enough to clearly indicate it must
be replaced. Wrap the placeholder with angle brackets (change
`your-addon-package-name` to `<your-addon-package-name>`) to make it explicit
that this is a placeholder value that users need to substitute with their actual
addon package name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e756db62-ab31-4463-bcc8-deb8365de62f
📒 Files selected for processing (1)
docs/addons/integration-catalog.mdx
|
Hi @jonniebigodes, I’ve addressed the review feedback and kept the PR focused on the timing/troubleshooting section. Could you take another look when you have time? |
jonniebigodes
left a comment
There was a problem hiding this comment.
@krish-mittal1 thanks for addressing the feedback so promptly. I've checked and it all looks good on my end.
Will merge once the checklist clears.
Have a fantastic day
Stay safe
Refs #35159
What I did
Updated the addon catalog timing section with a quick
npm viewcheck before opening an issue about a missing addon.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Read
docs/addons/integration-catalog.mdxand check that the timing section tells addon authors what to verify before opening an issue.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.?? Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
npm view <package> --jsonto verify the latest catalog metadata.npm viewcommand output.