Skip to content

Docs: Fix typo in package name in interaction testing#35103

Merged
Sidnioulz merged 5 commits into
storybookjs:nextfrom
Juicy1011:patch-1
Jun 17, 2026
Merged

Docs: Fix typo in package name in interaction testing#35103
Sidnioulz merged 5 commits into
storybookjs:nextfrom
Juicy1011:patch-1

Conversation

@Juicy1011

@Juicy1011 Juicy1011 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Fixed a typo in the /docs/writing-tests/interaction-testing.mdx file line 57. The error : ...We (and [Testing Libary](https://testing-library... changes the word Libary to Library

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Not applicable; this is a simple documentation contribution that fixes a typo in the text.

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Declare whether manual QA will be needed for this PR during the next release, through qa:needed or qa:skip

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Documentation
    • Fixed typo in the interaction testing guide.
    • Clarified that query priority order should be followed and that queries should mimic real user interactions.

Fixed a typo in the /docs/writing-tests/interaction-testing.mdx file line 57. The error : ...We (and [Testing Libary](https://testing-library... changes the word Libary to Library
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR corrects a typo in the interaction testing documentation ("Testing Libary" → "Testing Library") and adds a clarifying sentence about following the query priority order when using Testing Library utilities.

Changes

Interaction Testing Documentation

Layer / File(s) Summary
Query ordering documentation clarification
docs/writing-tests/interaction-testing.mdx
Typo fix correcting "Testing Libary" to "Testing Library" in the callout section, plus added sentence clarifying that query priority order should be followed when querying like a real user.

🎯 1 (Trivial) | ⏱️ ~2 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/writing-tests/interaction-testing.mdx`:
- Line 57: Replace the awkward fragment about `data-testid` with a direct
recommendation: update the sentence that begins with "While using `data-testid`
should be a last resort…" to read clearly and assertively (for example: "Use
`data-testid` only as a last resort, after trying every other query approach.").
Ensure the revised sentence sits after the Testing Library reference and keeps
the original emphasis on preferring accessible queries (e.g., role-based
queries) before `data-testid`.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a1089467-69b1-4761-a377-a81a42fe5969

📥 Commits

Reviewing files that changed from the base of the PR and between 6ce2b2b and fb1999d.

📒 Files selected for processing (1)
  • docs/writing-tests/interaction-testing.mdx

Comment thread docs/writing-tests/interaction-testing.mdx
@jonniebigodes jonniebigodes self-assigned this Jun 9, 2026
@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. and removed agent-scan:human labels Jun 9, 2026
@jonniebigodes jonniebigodes changed the title Fix typo in interaction testing documentation Doc: Fix typo in package name in interaction testing Jun 9, 2026

@jonniebigodes jonniebigodes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Juicy1011 thanks for taking the time to put together this pull request and helping us improve the documentation by catching this small typo. We appreciate it 🙏

I've checked and all looks good on my end.

Will gladly merge this once the checklist clears.

Hope you have an amazing day.

Stay safe

@jonniebigodes jonniebigodes changed the title Doc: Fix typo in package name in interaction testing Docs: Fix typo in package name in interaction testing Jun 9, 2026
@jonniebigodes jonniebigodes added the qa:skip Pull Requests that do not need any QA. label Jun 9, 2026
@Sidnioulz Sidnioulz moved this to Empathy Queue (prioritized) in Core Team Projects Jun 12, 2026
@Sidnioulz Sidnioulz merged commit 4046318 into storybookjs:next Jun 17, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Empathy Queue (prioritized) to Done in Core Team Projects Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. documentation qa:skip Pull Requests that do not need any QA.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants