Build: Fix bench-packages BigQuery BOOL/STRING type error#35100
Merged
Conversation
When `--base-branch` is passed without a value (e.g. because `ghBaseBranch` pipeline parameter expands to empty string), Commander.js sets `options.baseBranch = true` (boolean). The truthiness guard `if (options.baseBranch)` passes, and the boolean is sent as a BigQuery parameter of type BOOL, causing: No matching signature for operator = for argument types: STRING, BOOL Use `typeof options.baseBranch === 'string'` — already the pattern for the GCP_CREDENTIALS guard just above — so a boolean `true` correctly skips the comparison instead of crashing. AI-Generated: true
Sidnioulz
changed the title
Sidnioulz
added
build
Contributor
|
This is fixing a symptom, not the root issue, but aligns with prior symptom fixes and might help get the CI job from failing to non-failing. |
Sidnioulz
approved these changes
Jun 9, 2026
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No matching signature for operator = for argument types: STRING, BOOL--base-branchis passed without a value, Commander.js setsoptions.baseBranch = true(boolean). This happens when<< pipeline.parameters.ghBaseBranch >>expands to an empty string in CI, making the shell see--base-branch --pull-request ...— Commander then has no string value to consume and falls back to booleantrue.if (options.baseBranch)guard passes for truthy booleans, socompareResultswas called withbaseBranch = true, which the@google-cloud/bigqueryclient serialised as a BOOL parameter — crashing against the STRINGbranchcolumn.typeof options.baseBranch === 'string', consistent with the existingtypeof options.baseBranch === 'string'guard already present a few lines above for the GCP_CREDENTIALS check.Manual testing
Must pass
benchmark-packagesafter pushing to next. Can't be tested beforehand in real conditionsTest plan
benchmark-packagesjob passes on next push tonexthttps://app.circleci.com/agents/gh/storybookjs/chat/a7320ab8-4f8a-4178-9e08-f13ca4a22e26