Preview: Use width/height instead of min-* in CanvasWrap#35056
Merged
Sidnioulz merged 1 commit intoJun 5, 2026
Conversation
Revert the change from PR storybookjs#33290 that switched from explicit width/height to min-width/min-height, which broke full-height layout in Firefox ESR. Fixes storybookjs#33743
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe preview canvas sizing behavior is adjusted in the ChangesPreview Canvas Sizing
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
Sidnioulz
approved these changes
Jun 5, 2026
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix full-height layout in Firefox ESR for the story preview area.
PR #33290 changed the
CanvasWrapstyled component from usingwidth: 100%; height: 100%tomin-width: 100%; min-height: 100%. In Firefox ESR,min-height: 100%does not properly fill the available space when the parent has a defined height, causing the preview area to collapse vertically.Changes:
minWidth: '100%'→width: '100%'andminHeight: '100%'→height: '100%'inCanvasWrapFixes #33743
Manual testing
Summary by CodeRabbit
Release Notes