Svelte: Scope Starter Page Styles#35027
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughSix Svelte Page component templates across svelte-vite, sveltekit, and svelte renderer frameworks transition from importing external ChangesPage Component Style Consolidation
🎯 2 (Simple) | ⏱️ ~10 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for the Danger feedback. I updated the PR title and added the required #### Manual testing\ section. I do not have permission to add labels to this repository; could a maintainer please add the appropriate labels, likely \�ug, \ci:normal, and \qa:skip? |
|
Closing due to #23862 (comment) |
Summary
<style>blocks./page.cssimport from Svelte, SvelteKit, and Svelte Vite starter Page templatesFixes #23862
Verification
rg "import './page\\.css';" work/storybook-api/files/code/frameworks/svelte-vite work/storybook-api/files/code/frameworks/sveltekit work/storybook-api/files/code/renderers/svelte -nproduced no matches<style>blockstorybookjs/storybook:nextis ahead by 1, behind by 0, and touches only the six intended Svelte Page templatesFull Storybook lint/CI was not run locally because cloning the full repository timed out in this environment; the change is limited to generated starter template source files.
Manual testing
<section>element and confirm it no longer receives the starter Page styles.