Danger: Add QA labeling requirement to all PRs#35011
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repo’s Danger.js PR checks to require explicit QA labeling on pull requests, aligning labeling with a “declare QA needs at authoring time” workflow.
Changes:
- Added a new allowed QA label set:
qa:needed,qa:skip,qa:success. - Extended
checkRequiredLabels()to fail PRs missing a QA label, or having multiple QA labels.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds a ChangesQA Label Enforcement
🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Comment |
05e49cd to
1773b7f
Compare
What I did
Modified team process for QA requirements. Instead of labeling all QA worthy PRs at the end of a cycle, and then removed the QA label post QA, we'll now indicate on each PR whether it is QA worthy or not at the time of authoring. Then, the release team will go through all QA worthy PRs and label them as successful post-QA. This should help:
Checklist for Contributors
Manual testing
N/A
Documentation
N/A
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit