AI: Tell agents to preserve generated code unless relevant changes#34970
Conversation
d73228a to
0992cbf
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdates ChangesAgent Documentation Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Comment |
0992cbf to
5a10925
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit instruction to AGENTS.md telling agents not to commit accidental overrides of generated files (e.g., code/core/src/manager/globals/exports.ts), and slightly widens the Environment Variables table to accommodate the existing FIX_ON_COMMIT row.
Changes:
- Add a new Review Self-Check bullet warning against committing accidental changes to generated files.
- Reformat the Environment Variables table column widths for alignment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What I did
Told agents to stop mutating files like
code/core/src/manager/globals/exports.tsunintentionally. Those should be handled by us if they become flaky, to avoid noise on dozens of PRs.Checklist for Contributors
Testing
ø
Manual testing
Run agent workflows from this branch and check if
SupportedFrameworkkeeps getting added/removed fromcode/core/src/manager/globals/exports.ts.Documentation
Checklist for Maintainers
When this PR is ready for testing, make sure to addIRRELEVANTci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
Note: This release contains no user-facing changes.