Skip to content

Build: Remove borked submodules#34862

Merged
Sidnioulz merged 2 commits into
nextfrom
sidnioulz/no-submodules
May 21, 2026
Merged

Build: Remove borked submodules#34862
Sidnioulz merged 2 commits into
nextfrom
sidnioulz/no-submodules

Conversation

@Sidnioulz
Copy link
Copy Markdown
Member

@Sidnioulz Sidnioulz commented May 21, 2026

What I did

Removes submodules that Jeppe committed accidentally. Those caused warnings in the cleanup step of our github/checkout actions, and the warnings now turn into errors with checkout v6.

Checklist for Contributors

Testing

ø

Manual testing

ø

We'll need to merge to see the effects on the next pipeline.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow configuration to streamline pull request checks.
    • Updated multiple internal submodule dependencies to their latest versions.

Review Change Stack

Copilot AI review requested due to automatic review settings May 21, 2026 06:51
@Sidnioulz Sidnioulz added build Internal-facing build tooling & test updates ci:normal labels May 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Danger JS GitHub Actions workflow to avoid checking out git submodules, preventing failures introduced by actions/checkout@v6 when submodules are present/misconfigured.

Changes:

  • Remove submodules: true from the actions/checkout step in the pull_request_target Danger workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 777ca5d1-c74f-4031-8956-ecfcfe8dd2d8

📥 Commits

Reviewing files that changed from the base of the PR and between 46eba0b and 2af6a21.

📒 Files selected for processing (12)
  • .github/workflows/danger-js.yml
  • .rollout-repos/addon-coverage
  • .rollout-repos/addon-designs
  • .rollout-repos/addon-kit
  • .rollout-repos/addon-styling-webpack
  • .rollout-repos/addon-visual-tests
  • .rollout-repos/addon-webpack5-compiler-babel
  • .rollout-repos/addon-webpack5-compiler-swc
  • .rollout-repos/icons
  • .rollout-repos/telejson
  • .rollout-repos/test-runner
  • .rollout-repos/vite-plugin-storybook-nextjs
💤 Files with no reviewable changes (12)
  • .rollout-repos/vite-plugin-storybook-nextjs
  • .rollout-repos/addon-visual-tests
  • .rollout-repos/addon-styling-webpack
  • .rollout-repos/icons
  • .rollout-repos/addon-coverage
  • .rollout-repos/test-runner
  • .rollout-repos/addon-webpack5-compiler-swc
  • .rollout-repos/addon-kit
  • .rollout-repos/addon-webpack5-compiler-babel
  • .rollout-repos/addon-designs
  • .rollout-repos/telejson
  • .github/workflows/danger-js.yml

📝 Walkthrough

Walkthrough

The PR disables recursive submodule checkout in the Danger JS GitHub Actions workflow and updates git submodule pointer references in .rollout-repos/. The workflow no longer passes submodules: true to actions/checkout, and multiple submodule gitlink entries are either removed or updated to reference different commits.

Changes

Submodule handling refactor

Layer / File(s) Summary
Danger JS workflow submodule checkout removal
.github/workflows/danger-js.yml
Removes submodules: true from the actions/checkout step, leaving the checkout configured only with base ref and persist-credentials: false settings.
Submodule pointer updates in rollout repos
.rollout-repos/addon-designs, .rollout-repos/addon-webpack5-compiler-babel
Git submodule references are updated: the addon-designs submodule is removed, and the addon-webpack5-compiler-babel submodule reference is updated to a new commit pointer.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • storybookjs/storybook#34848: Both PRs address git submodule handling in CI workflows—this PR disables submodule checkout in danger-js.yml and updates .rollout-repos/* references, while the related PR removes accidental .external/* gitlink entries that broke actions/checkout's recursive submodule step.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sidnioulz Sidnioulz merged commit d35ac5f into next May 21, 2026
139 of 146 checks passed
@Sidnioulz Sidnioulz deleted the sidnioulz/no-submodules branch May 21, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants