Build: Remove borked submodules#34862
Conversation
This reverts commit 46eba0b.
There was a problem hiding this comment.
Pull request overview
This PR updates the Danger JS GitHub Actions workflow to avoid checking out git submodules, preventing failures introduced by actions/checkout@v6 when submodules are present/misconfigured.
Changes:
- Remove
submodules: truefrom theactions/checkoutstep in thepull_request_targetDanger workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
💤 Files with no reviewable changes (12)
📝 WalkthroughWalkthroughThe PR disables recursive submodule checkout in the Danger JS GitHub Actions workflow and updates git submodule pointer references in ChangesSubmodule handling refactor
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Comment |
What I did
Removes submodules that Jeppe committed accidentally. Those caused warnings in the cleanup step of our github/checkout actions, and the warnings now turn into errors with checkout v6.
Checklist for Contributors
Testing
ø
Manual testing
ø
We'll need to merge to see the effects on the
nextpipeline.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit