-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Maintenance: Centralize supported file extension lists #34844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
valentinpalkovic
merged 2 commits into
next
from
valentin/centralize-supported-extensions
May 26, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
code/core/src/core-server/change-detection/parser-registry/builtins.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /** | ||
| * JS-only module extensions. Used by code that loads runtime JS modules through Node's resolver | ||
| * without TypeScript transpilation in scope. | ||
| */ | ||
| export const jsModuleExtensions = ['.mjs', '.js', '.cjs'] as const; | ||
|
|
||
| /** | ||
| * JS/TS source file extensions (incl. JSX/TSX). Used by parsers, bundlers, and other tooling that | ||
| * understands both languages but not framework single-file-component formats. | ||
| */ | ||
| export const jsTsSourceExtensions = ['.ts', '.tsx', '.js', '.jsx', '.mjs', '.cjs'] as const; | ||
|
|
||
| /** | ||
| * Storybook config file extensions for `main.{ext}`, `preview.{ext}`, `manager.{ext}`. Covers the | ||
| * JS/TS family plus the Node module-system variants (`.mts`, `.cts`, etc.). | ||
| */ | ||
| export const storybookConfigExtensions = [ | ||
| '.js', | ||
| '.ts', | ||
| '.jsx', | ||
| '.tsx', | ||
| '.mjs', | ||
| '.mts', | ||
| '.mtsx', | ||
| '.cjs', | ||
| '.cts', | ||
| '.ctsx', | ||
| ] as const; | ||
|
|
||
| /** | ||
| * Module file extensions for user-code resolution (e.g. `sb.mock()`). Covers JS/TS plus JSON and | ||
| * common single-file-component types (`.vue`, `.svelte`). | ||
| */ | ||
| export const userModuleExtensions = [ | ||
| '.astro', | ||
| '.js', | ||
| '.mjs', | ||
| '.cjs', | ||
| '.ts', | ||
| '.tsx', | ||
| '.jsx', | ||
| '.json', | ||
| '.vue', | ||
| '.svelte', | ||
| ] as const; | ||
|
valentinpalkovic marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for that!
WDYT about my suggestion on the other PR to also add e.g. Solid or Astro? Like Vue and Svelte, these are supported when the relevant framework is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has Solid its own file extension and DSL? I'm okay with adding astro for sure!