Skip to content

Scripts: Fallback to CP + rm for cross-disk dir move in generate task #34755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JReinhold merged 1 commit into from
May 12, 2026
Merged

Scripts: Fallback to CP + rm for cross-disk dir move in generate task #34755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion scripts/sandbox/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,20 @@ const emptyDir = async (dir: string): Promise<void> => {
await Promise.all(names.map((name) => rm(join(dir, name), { recursive: true, force: true })));
};

const moveDir = async (from: string, to: string): Promise<void> => {
try {
await rename(from, to);
} catch (error) {
// On some platforms (notably Windows), rename doesn't work across different disks volumes
if ((error as NodeJS.ErrnoException).code !== 'EXDEV') {
throw error;
}

await cp(from, to, { recursive: true });
await rm(from, { recursive: true, force: true });
}
};

const addStorybook = async ({
localRegistry,
baseDir,
Expand Down Expand Up @@ -266,7 +280,7 @@ const runGenerators = async (
await localizeYarnConfigFiles(createBaseDir, createBeforeDir);

// Now move the created before dir into it's final location and add storybook
await rename(createBeforeDir, beforeDir);
await moveDir(createBeforeDir, beforeDir);

// Make sure there are no git projects in the folder
await rm(join(beforeDir, '.git'), { recursive: true, force: true });
Expand Down
Loading