Skip to content

Core: Fix "Open In Editor" support for VSCode#34747

Merged
JReinhold merged 2 commits into
nextfrom
jeppe/fix-launch-vscode
May 11, 2026
Merged

Core: Fix "Open In Editor" support for VSCode#34747
JReinhold merged 2 commits into
nextfrom
jeppe/fix-launch-vscode

Conversation

@JReinhold
Copy link
Copy Markdown
Contributor

@JReinhold JReinhold commented May 7, 2026

Closes #

What I did

The "Open In Editor" functionality was broken for me. It would either not launch anything or open the file in vim in the terminal.

Turns out VSCode changed their bin paths recently on MacOS, so the launch-editor pacakge was unable to detect it on my machine. Upgrading that package fixed the issue.

See yyx990803/launch-editor#112

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Only have VSCode running as an editor (or Insiders)
  2. Compile and start up the UI Storybook
  3. Click the "Open in editor" button in the top right corner.
  4. See the file opening in VSCode

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated a development dependency to a newer version for improved stability and maintenance.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1cd0559b-2955-4244-8459-758f6e2b0765

📥 Commits

Reviewing files that changed from the base of the PR and between 245043f and d5cbf95.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • code/core/package.json

📝 Walkthrough

Walkthrough

This PR updates the launch-editor development dependency from version ^2.11.1 to ^2.13.2 in code/core/package.json. The change is a minor version bump with no modifications to exported entities, module wiring, or other package manifest fields.

Changes

Dependency Version Update

Layer / File(s) Summary
Dependency Version Bump
code/core/package.json
launch-editor dev dependency updated from ^2.11.1 to ^2.13.2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

@JReinhold JReinhold merged commit 4fd4885 into next May 11, 2026
109 checks passed
@JReinhold JReinhold deleted the jeppe/fix-launch-vscode branch May 11, 2026 07:18
@github-actions github-actions Bot mentioned this pull request May 11, 2026
32 tasks
valentinpalkovic added a commit to storybookjs/sandboxes that referenced this pull request May 11, 2026
Check the diff here: storybookjs/storybook@b2167d6...e1df708

List of included PRs since previous version:
- storybookjs/storybook#34747 (jeppe/fix-launch-vscode)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants