fix: narrow CSF factory decorator context types#34687
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
💤 Files with no reviewable changes (14)
📝 WalkthroughWalkthroughAdded conditional helper types ChangesTypeScript Type Definition Refinement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Updated this PR to fix the failing What changed:
Verification:
No source files were changed. |
Closes #33801
What I did
parametersand typedglobalsin CSF factories.AI assistance was used to prepare this contribution.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
No manual browser testing was needed; this is a TypeScript type inference fix. I ran:
yarn exec oxfmt --check code/core/src/csf/story.ts code/core/src/csf/csf-factories.test.ts code/core/src/preview-api/modules/store/csf/portable-stories.tscode/core/src/csf/csf-factories.test.tsyarn vitest run --config code/core/vitest.config.ts code/core/src/csf/csf-factories.test.tsNODE_OPTIONS=--max-old-space-size=4096 yarn exec jiti ./scripts/check/check-package.ts --cwd code/coreDocumentation
MIGRATION.MD
Summary by CodeRabbit
Tests
Refactor
Chores