Skip to content

Release: Prerelease 10.4.0-alpha.15 #34682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yannbf merged 3 commits into from
May 1, 2026
+14 −7
Merged

Release: Prerelease 10.4.0-alpha.15 #34682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d5ea95
move agent detection to config hook instead of configureVitest
JReinhold May 1, 2026
4dfac81
Merge pull request #34681 from storybookjs/jeppe/fix-vitest-provide-a…
JReinhold May 1, 2026
9681b6a
Write changelog for 10.4.0-alpha.15 [skip ci]
storybook-bot May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.prerelease.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 10.4.0-alpha.15

- Vitest: Fix agent detection breaking runs - [#34681](https://github.com/storybookjs/storybook/pull/34681), thanks @JReinhold!

## 10.4.0-alpha.14

- CLI: Fix agentic check - [#34678](https://github.com/storybookjs/storybook/pull/34678), thanks @yannbf!
Expand Down
14 changes: 8 additions & 6 deletions code/addons/vitest/src/vitest-plugin/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ export const storybookTest = async (options?: UserOptions): Promise<Plugin[]> =>
plugins.push(mdxStubPlugin);
}

let agent: ReturnType<typeof detectAgent> | undefined;
let withinAgenticSetupSession = false;

const storybookTestPlugin: Plugin = {
Expand All @@ -267,6 +268,11 @@ export const storybookTest = async (options?: UserOptions): Promise<Plugin[]> =>
.replace('<body>', `<body>${bodyHtmlSnippet ?? ''}`);
},
async config(nonMutableInputConfig, { mode }) {
if (isTelemetryModuleEnabled()) {
agent = detectAgent();
withinAgenticSetupSession = !!agent && (await isWithinInitialSession('ai-setup'));
}

if (mode) {
// Needed for `preset.apply('env')` to work correctly
process.env.BUILD_TARGET = mode;
Expand Down Expand Up @@ -367,7 +373,8 @@ export const storybookTest = async (options?: UserOptions): Promise<Plugin[]> =>

provide: {
[STORYBOOK_CORE_GHOST_STORIES_PROVIDE_KEY]: !!process.env.STORYBOOK_COMPONENT_PATHS,
[STORYBOOK_CORE_RENDER_ANALYSIS_PROVIDE_KEY]: !!process.env.STORYBOOK_COMPONENT_PATHS,
[STORYBOOK_CORE_RENDER_ANALYSIS_PROVIDE_KEY]:
!!process.env.STORYBOOK_COMPONENT_PATHS || withinAgenticSetupSession,
},

include: [...includeStories, ...getComponentTestPaths()],
Expand Down Expand Up @@ -458,11 +465,6 @@ export const storybookTest = async (options?: UserOptions): Promise<Plugin[]> =>
if (isTelemetryModuleEnabled()) {
// When an agent is running vitest via CLI, inject a reporter that sends
// detailed test result telemetry (pass/fail, error analysis, empty renders)
const agent = detectAgent();
withinAgenticSetupSession = !!agent && (await isWithinInitialSession('ai-setup'));
if (withinAgenticSetupSession) {
await context.vitest.provide(STORYBOOK_CORE_RENDER_ANALYSIS_PROVIDE_KEY, true);
}
if (agent && withinAgenticSetupSession) {
context.vitest.config.reporters.push(
new AgentTelemetryReporter({
Expand Down
3 changes: 2 additions & 1 deletion code/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,5 +196,6 @@
"Dependency Upgrades"
]
]
}
},
"deferredNextVersion": "10.4.0-alpha.15"
}
Loading