UI: Show sidebar focus ring for selected item#34658
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes add visual selection indication to sidebar items by introducing a dedicated CSS rule with an inset box-shadow for selected elements marked with Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
|
Thank you for your contribution! Whilst we appreciate the effort you put into your PR, there’s already another PR (#33422) addressing the same need, which we’ve started reviewing before yours. We’d love for you to keep contributing, though! Here’s a link to [open issues without existing PRs](https://github.com/storybookjs/storybook/issues?q=is%3Aissue%20state%3Aopen%20-linked%3Apr) where your help would be greatly appreciated! |
Closes #24186
What I did
AI assistance: Codex via Hermes Agent was used to prepare this PR.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
No browser manual test was run in this environment. I verified the targeted sidebar styling behavior with the unit test and local checks below:
yarn vitest run --config code/core/vitest.config.ts code/core/src/manager/components/sidebar/__tests__/HighlightStyles.test.tsxyarn --cwd code lint:js:cmd core/src/manager/components/sidebar/HighlightStyles.tsx core/src/manager/components/sidebar/__tests__/HighlightStyles.test.tsx --fixyarn nx compile coreyarn nx check coregit diff --check HEAD~1..HEADDocumentation
MIGRATION.MD
Summary by CodeRabbit
New Features
Tests