-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Eval: Add sync-storybook-version harness + --skip-automigrations upgrade flag #34612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yannbf
merged 4 commits into
project/sb-agentic-setup
from
kasper/eval-sync-storybook-version
Apr 28, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7cb6490
Eval: add sync-storybook-version script + --skip-automigrations
kasperpeulen 8c8312b
Eval: hoist default sync hooks to avoid TDZ from CLI entry
kasperpeulen d8de741
Eval: let reruns push existing local sync commits
kasperpeulen 448d4d4
CI: type sync-storybook-version env as NodeJS.ProcessEnv
kasperpeulen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable shadowing causes signal handler to always see empty automigration results.
Line 341 declares
const automigrationResultsin the outer scope, which is captured by thehandleInterruptionclosure (line 348). The newlet automigrationResultsat line 418 creates a shadowing variable in the inner scope.If a user interrupts (SIGINT/SIGTERM) after automigrations complete, the signal handler will send telemetry with empty
automigrationResultsbecause it references the outer empty object, not the inner populated one.🐛 Proposed fix: Remove shadowing by reassigning the outer variable
Also change line 341 from
consttoletto allow reassignment, or useObject.assignas shown above to mutate the existing object in place.🤖 Prompt for AI Agents