Build: NX resource-class eval — linux-browsers-js = medium#34578
Closed
kasperpeulen wants to merge 27 commits into
Closed
Build: NX resource-class eval — linux-browsers-js = medium#34578kasperpeulen wants to merge 27 commits into
kasperpeulen wants to merge 27 commits into
Conversation
|
View your CI Pipeline Execution ↗ for commit 469e2db
☁️ Nx Cloud last updated this comment at |
0879af6 to
197084d
Compare
dd80ee5 to
caf23ba
Compare
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
NX Cloud resource-class sweep — branch 6 of 6. Do not merge.
Changes exactly one line:
.nx/workflows/agents.yaml→linux-browsers-js.resource-class = docker_linux_amd64/medium(10 credits/min).Part of measuring the real cost / duration / flake curve across
linux-browsers-jsresource classes on realci:normaltraffic. Replaces the single linearly-extrapolated "medium+ projected" column in the NX-vs-CircleCI findings canvas with a 6-point data-backed curve.linux-jsstays atextra_large+across all branches. Parent branchkasper/nx-ai(#34282) strips CircleCI +NX_EXPERIMENTso these 6 PRs only exercise NX Cloud.Sweep matrix:
kasper/nx-rc-xlarge-plusextra_large+kasper/nx-rc-xlargeextra_largekasper/nx-rc-large-pluslarge+kasper/nx-rc-largelargekasper/nx-rc-medium-plusmedium+kasper/nx-rc-mediummediumTraffic plan: cache-bust every ~10 min per branch until 30 runs/branch or Enterprise trial expiry (2026-04-19). Data →
scripts/ci-eval.db→ new "Resource class sweep" section in the findings canvas with cost + duration bar charts and a measured recommendation.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
No manual test necessary — this PR exists only to exercise CI traffic. Verify by opening the PR's NX Cloud CIPE (GH check
nx: normal) and confirming thelinux-browsers-jsagents are running ondocker_linux_amd64/medium(visible in the agent metadata on cloud.nx.app). The sync scriptscripts/evaluate-ci.tsrecordscredit_multiplier = 10per CIPE inscripts/ci-eval.db.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>