Skip to content

Build: NX evaluation — ci:daily #2#34565

Closed
kasperpeulen wants to merge 9 commits into
kasper/nx-aifrom
kasper/nx-eval-daily-2
Closed

Build: NX evaluation — ci:daily #2#34565
kasperpeulen wants to merge 9 commits into
kasper/nx-aifrom
kasper/nx-eval-daily-2

Conversation

@kasperpeulen
Copy link
Copy Markdown
Member

@kasperpeulen kasperpeulen commented Apr 16, 2026

What I did

Automated evaluation PR for NX Cloud vs CircleCI comparison.

Workflow: ci:daily

This PR exists only to collect CI run data for the NX vs CircleCI evaluation. Retrigger pushes will bust the NX cache via codexCacheBust in nx.json to ensure fresh runs on both systems.

Do not merge.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

No manual testing needed — this PR only triggers CI runs for data collection.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:daily or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

@kasperpeulen kasperpeulen added the ci:daily Run the CI jobs that normally run in the daily job. label Apr 16, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 16, 2026

View your CI Pipeline Execution ↗ for commit 2e66d25

Command Status Duration Result
nx run-many -t compile,check,knip,test,lint,fmt... ✅ Succeeded 16m 15s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-16 15:55:25 UTC

@kasperpeulen kasperpeulen changed the base branch from next to kasper/nx-ai April 16, 2026 10:23
@kasperpeulen kasperpeulen marked this pull request as draft April 16, 2026 10:23
@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label Apr 16, 2026
@kasperpeulen kasperpeulen changed the title NX Evaluation: ci:daily #2 (do not merge) Build: NX evaluation — ci:daily #2 Apr 16, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

Caution

Review failed

Failed to post review comments

📝 Walkthrough

Walkthrough

This PR introduces experimental NX Cloud CI improvements by adding an NX_EXPERIMENT flag to gate job inclusion, integrating new Storybook initialization targets (init-empty and init-features) across sandbox projects, migrating MCP server configuration from wallaby to nx-mcp, and introducing a comprehensive CI evaluation script for comparing CircleCI and NX Cloud performance metrics and costs.

Changes

Cohort / File(s) Summary
MCP & Dependencies
.cursor/mcp.json, package.json
Replaced MCP server from wallaby to nx-mcp with updated command/args; bumped @nx/workspace and nx to ^22.6.5.
GitHub Actions Workflow
.github/workflows/nx.yml
Added workflow-level concurrency grouping, set NX_CI_EXECUTION_ENV: 'linux' in job environment, added commented-out Windows CI jobs, and improved formatting.
Nx Workflow Configuration
.nx/workflows/agents.yaml, .nx/workflows/assignment-rules-windows.yaml, .nx/workflows/distribution-config-daily.yaml
Reduced Linux agent resource class from extra_large+ to medium+, removed Windows agent definition, added Windows assignment rules with serialized compilation, and scheduled init targets to linux-js agent.
Sandbox Project Targets
code/sandbox/lit-vite-default-ts/project.json, code/sandbox/nextjs-default-ts/project.json, code/sandbox/react-vite-default-ts/project.json, code/sandbox/vue3-vite-default-ts/project.json
Added init-empty target to all sandboxes; added init-features to React sandbox; appended ci:windows tag to React sandbox project.
Core Configuration
code/project.json, scripts/project.json, nx.json
Updated test command invocation and cache inputs; added storybook-build and storybook-chromatic targets; defined new init-empty and init-features target defaults with create-storybook@latest scaffolding; added bench-packages target to scripts; updated codexCacheBust timestamp.
CI Script Updates
scripts/ci/main.ts, scripts/ci/init-empty.ts, scripts/ci/sandboxes.ts, scripts/create-nx-sandbox-projects.ts
Introduced NX_EXPERIMENT flag to conditionally exclude Windows jobs, storybook chromatic, and benchmarks; updated function signatures to accept nxExperiment option; added template mapping for init-empty/init-features target generation in sandbox projects.
CI Evaluation Tool
scripts/evaluate-ci.ts
New comprehensive script (632 lines) that queries CircleCI and NX Cloud APIs to compare CI runs, compute credits/costs, and produce per-system reports with duration statistics and flake rates.
Code Changes
code/lib/codemod/src/index.ts
Modified tinyglobby invocation to use { absolute: true } option, changing returned file paths from relative to absolute for downstream processing.
Test Configuration
test-storybooks/portable-stories-kitchen-sink/react-vitest-3/project.json, test-storybooks/yarn-pnp/project.json
Removed or modified CI tags: removed ci:normal from react-vitest-3; changed yarn-pnp tags from ["ci:normal", "ci:merged", "ci:daily"] to ["ci:daily"].

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@kasperpeulen
Copy link
Copy Markdown
Member Author

Superseded by RC-sweep experiment — closing to wind down this branch's CI traffic. Branch intentionally not deleted (DB data references it). Do not merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant