Skip to content

Build: NX evaluation — ci:daily #1#34564

Closed
kasperpeulen wants to merge 9 commits into
kasper/nx-aifrom
kasper/nx-eval-daily-1
Closed

Build: NX evaluation — ci:daily #1#34564
kasperpeulen wants to merge 9 commits into
kasper/nx-aifrom
kasper/nx-eval-daily-1

Conversation

@kasperpeulen
Copy link
Copy Markdown
Member

@kasperpeulen kasperpeulen commented Apr 16, 2026

What I did

Automated evaluation PR for NX Cloud vs CircleCI comparison.

Workflow: ci:daily

This PR exists only to collect CI run data for the NX vs CircleCI evaluation. Retrigger pushes will bust the NX cache via codexCacheBust in nx.json to ensure fresh runs on both systems.

Do not merge.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

No manual testing needed — this PR only triggers CI runs for data collection.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:daily or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

@kasperpeulen kasperpeulen added the ci:daily Run the CI jobs that normally run in the daily job. label Apr 16, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 16, 2026

View your CI Pipeline Execution ↗ for commit 6f27644

Command Status Duration Result
nx run-many -t compile,check,knip,test,lint,fmt... ✅ Succeeded 16m 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-16 15:40:10 UTC

@kasperpeulen kasperpeulen changed the base branch from next to kasper/nx-ai April 16, 2026 10:23
@kasperpeulen kasperpeulen marked this pull request as draft April 16, 2026 10:23
@kasperpeulen kasperpeulen changed the title NX Evaluation: ci:daily #1 (do not merge) Build: NX evaluation — ci:daily #1 Apr 16, 2026
@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label Apr 16, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

Caution

Review failed

Failed to post review comments

📝 Walkthrough

Walkthrough

This PR introduces Windows CI experimental support, adds new Storybook initialization targets (init-empty and init-features), implements an NX Cloud/CircleCI evaluation benchmarking tool, reorganizes Nx agent/workflow assignments, and applies a conditional nxExperiment flag to gate platform-specific CI jobs.

Changes

Cohort / File(s) Summary
MCP & CI Tooling Configuration
.cursor/mcp.json, .github/workflows/nx.yml
Replaced Wallaby MCP server with nx-mcp command. Added workflow-level concurrency grouping and Linux execution environment to main job; appended commented-out Windows CI job variants with Windows-specific configuration and conditional daily scheduling.
Nx Agent & Workflow Assignment Configuration
.nx/workflows/agents.yaml, .nx/workflows/assignment-rules-windows.yaml, .nx/workflows/distribution-config-daily.yaml
Downgraded Linux browser resource class and removed Windows agent template. Added Windows assignment rules for task distribution and new init-empty/init-features target assignment to Linux agents with serialized execution.
Core Nx & Project Target Configuration
nx.json, code/project.json
Added init-empty and init-features target definitions to targetDefaults for Storybook initialization workflows. Updated code project test inputs and added new storybook-build and storybook-chromatic targets with caching and dependency configuration. Updated cache bust timestamp.
Sandbox Project Target Configuration
code/sandbox/lit-vite-default-ts/project.json, code/sandbox/nextjs-default-ts/project.json, code/sandbox/react-vite-default-ts/project.json, code/sandbox/vue3-vite-default-ts/project.json
Added init-empty target with environment variable configuration to each sandbox. Added init-features target and ci:windows tag to React Vite sandbox only.
Codemod & Sandbox Generation Scripts
code/lib/codemod/src/index.ts, scripts/create-nx-sandbox-projects.ts
Updated codemod file discovery to use absolute paths for Windows cross-drive compatibility. Added template mapping and conditional target injection logic for init-empty and init-features targets in sandbox project generation.
CI Generation & Orchestration Scripts
scripts/ci/main.ts, scripts/ci/init-empty.ts, scripts/ci/sandboxes.ts
Introduced NX_EXPERIMENT flag to conditionally gate Windows jobs, Storybook/benchmark tasks, and initialization jobs. Updated function signatures to accept experiment option and modified job selection logic accordingly.
CI Evaluation & Benchmarking Tool
scripts/evaluate-ci.ts, scripts/project.json
Added new benchmarking script that queries CircleCI and NX Cloud APIs, computes cost/credit metrics, flake rates, and duration analytics, then generates comparative reports. Added corresponding bench-packages Nx target in scripts project.
Dependencies & Metadata
package.json, test-storybooks/portable-stories-kitchen-sink/react-vitest-3/project.json, test-storybooks/yarn-pnp/project.json
Updated Nx dependencies to ^22.6.5. Removed or restricted CI tags on test-storybook projects.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@kasperpeulen
Copy link
Copy Markdown
Member Author

Superseded by RC-sweep experiment — closing to wind down this branch's CI traffic. Branch intentionally not deleted (DB data references it). Do not merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant