Build: NX evaluation — ci:normal#34562
Conversation
|
View your CI Pipeline Execution ↗ for commit c51a455
☁️ Nx Cloud last updated this comment at |
|
Caution Review failedFailed to post review comments 📝 WalkthroughWalkthroughThis PR introduces widespread CI/CD infrastructure changes including replacing the Wallaby MCP server with NX MCP, updating GitHub Actions workflow concurrency, restructuring Nx agent resource classes (downgrading Linux, removing Windows), adding new Windows assignment rules, implementing an NX_EXPERIMENT feature flag to conditionally exclude jobs, creating Storybook build targets, and adding a new CI evaluation script to compare CircleCI and NX Cloud performance metrics. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
Comment |
|
Superseded by RC-sweep experiment — closing to wind down this branch's CI traffic. Branch intentionally not deleted (DB data references it). Do not merge. |
What I did
Automated evaluation PR for NX Cloud vs CircleCI comparison.
Workflow:
ci:normalThis PR exists only to collect CI run data for the NX vs CircleCI evaluation. Retrigger pushes will bust the NX cache via
codexCacheBustinnx.jsonto ensure fresh runs on both systems.Do not merge.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
No manual testing needed — this PR only triggers CI runs for data collection.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>