Skip to content

Agentic Setup: Rename final scoring event#34549

Merged
yannbf merged 1 commit into
project/sb-agentic-setupfrom
sidnioulz/rename-story-scoring
Apr 15, 2026
Merged

Agentic Setup: Rename final scoring event#34549
yannbf merged 1 commit into
project/sb-agentic-setupfrom
sidnioulz/rename-story-scoring

Conversation

@Sidnioulz

@Sidnioulz Sidnioulz commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

ø

Summary by CodeRabbit

  • Chores
    • Updated internal telemetry tracking identifiers for the AI setup workflow's completion states to improve event consistency.

@Sidnioulz Sidnioulz added build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs). labels Apr 15, 2026
@Sidnioulz Sidnioulz requested a review from yannbf April 15, 2026 10:37
@nx-cloud

nx-cloud Bot commented Apr 15, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 512183d

Command Status Duration Result
nx run-many -t compile,check,knip,test,lint,fmt... ✅ Succeeded 11m 53s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-15 10:51:41 UTC

@yannbf yannbf merged commit 48a55f9 into project/sb-agentic-setup Apr 15, 2026
13 of 20 checks passed
@yannbf yannbf deleted the sidnioulz/rename-story-scoring branch April 15, 2026 10:38
@coderabbitai

coderabbitai Bot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8a2950c3-d291-4c0e-8b82-cebe669bdc4a

📥 Commits

Reviewing files that changed from the base of the PR and between 396eba6 and 512183d.

📒 Files selected for processing (2)
  • code/core/src/core-server/server-channel/ai-setup-channel.ts
  • code/core/src/telemetry/types.ts

📝 Walkthrough

Walkthrough

Telemetry event identifier renamed from ai-setup-story-scoring to ai-setup-final-scoring across two files. The AI analytics initialization now checks and emits using the updated event name; payload structure remains unchanged.

Changes

Cohort / File(s) Summary
Telemetry Event Rename
code/core/src/telemetry/types.ts, code/core/src/core-server/server-channel/ai-setup-channel.ts
Updated EventType union and all telemetry emissions to use ai-setup-final-scoring instead of ai-setup-story-scoring. Updated AI analytics initialization to check for completion using the new event key.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants