Release: Prerelease 10.4.0-alpha.10#34539
Merged
valentinpalkovic merged 36 commits intoApr 16, 2026
Merged
Conversation
Instead of requiring every telemetry call site to check `disableTelemetry`, introduce a module-level flag in the telemetry module that gates all calls. The `telemetry()` function now early-returns when disabled, making all callers safe by default. This fixes #34431 where `checklist.ts` was missing the guard, causing telemetry to be sent despite `disableTelemetry: true`. The flag is set at startup from CLI options (via `withTelemetry`) and from config (via preset loading in `buildDevStandalone`, `buildStaticStandalone`, and `experimental_serverChannel`). All ~20 scattered `if (!disableTelemetry)` guards have been removed. Closes #34431 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replaces the simple boolean flag with a three-state machine (uninitialized/enabled/disabled) that queues telemetry events until setTelemetryEnabled() is called, then flushes or discards them accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add `force: true` to error telemetry options so crash reports bypass the disabled state - Add `isTelemetryStateResolved` export to telemetry module for checking uninitialized state - Add fallback in `withTelemetry` finally block to conservatively disable telemetry when presets never resolved state, dropping queued events - Await `setTelemetryEnabled(false)` call for CLI disableTelemetry option Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Each test provider now declares a clear() function on its addon registration. SidebarBottom calls api.clearStatuses() which dispatches to each registered provider's clear(), so non-test statuses like change detection are preserved. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
A thrown exception from one provider's clear() no longer aborts remaining providers. Each call is wrapped in a try/catch that logs a warning (via client-logger) including the provider id. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… changeDetection in internal Storybook Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…t-factory-resolver-dependency Angular: Remove usage of `ComponentFactoryResolver`
When a telemetry payload factory throws or returns { error }, the
telemetry module now delegates to a registered error handler instead
of silently dropping the event. withTelemetry() registers
sendTelemetryError as the handler, so all commands benefit from
automatic error telemetry with full context (presets, cache, error
levels, sub-errors).
This removes the need for callers like doTelemetry to manually call
sendTelemetryError — they just return { error } from the callback.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…-umbrella Telemetry: Centralize disable logic with module-level flag
github-actions
Bot
requested review from
jonniebigodes and
kylegach
as code owners
github-actions
Bot
added
the
release
- Guard ensurePanel against null/undefined panels collection to prevent crash when test providers don't return a value for PANEL type - Wrap logger.warn in nested try-catch inside clearStatuses so a logging failure never stops iteration over remaining providers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Build: Remove vite-plus as devDependency
storybook-bot
force-pushed
the
version-non-patch-from-10.4.0-alpha.9
branch
from
743f74e to
45c4f1c
Compare
…ge-detection-statuses Sidebar: Fix clear status button to only clear test statuses
storybook-bot
force-pushed
the
version-non-patch-from-10.4.0-alpha.9
branch
from
45c4f1c to
1d29fb0
Compare
Build: Add FIX_ON_COMMIT env var to force autofix in pre-commit hook
storybook-bot
force-pushed
the
version-non-patch-from-10.4.0-alpha.9
branch
from
1d29fb0 to
6d323be
Compare
valentinpalkovic
added
ci:daily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
10.4.0-alpha.9to10.4.0-alpha.10.Once this pull request is merged, it will trigger a new release of version
10.4.0-alpha.10.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:ComponentFactoryResolver#34535If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
10.4.0-alpha.10