fix(checklist): respect disableTelemetry config in initializeChecklist #34435
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,49 @@ | ||||||
| import { describe, expect, it } from 'vitest'; | ||||||
|
|
||||||
| import { isConfigAlreadySetup } from './postinstall'; | ||||||
|
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion | 🟠 Major Missing file extension on relative import. As per coding guidelines, TypeScript files should use explicit file extensions for relative imports. 🔧 Suggested fix-import { isConfigAlreadySetup } from './postinstall';
+import { isConfigAlreadySetup } from './postinstall.ts';📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| describe('postinstall helpers', () => { | ||||||
| it('detects a fully configured Vitest config with addon plugin', () => { | ||||||
| const config = ` | ||||||
| import { defineConfig } from 'vitest/config'; | ||||||
| import { storybookTest } from '@storybook/addon-vitest/vitest-plugin'; | ||||||
|
|
||||||
| export default defineConfig({ | ||||||
| test: { | ||||||
| projects: [ | ||||||
| { | ||||||
| extends: true, | ||||||
| plugins: [storybookTest({ configDir: '.storybook' })], | ||||||
| test: { | ||||||
| setupFiles: ['./.storybook/vitest.setup.ts'], | ||||||
| }, | ||||||
| }, | ||||||
| ], | ||||||
| }, | ||||||
| }); | ||||||
| `; | ||||||
|
|
||||||
| expect(isConfigAlreadySetup('/project/vitest.config.ts', config)).toBe(true); | ||||||
| }); | ||||||
|
|
||||||
| it('returns false when storybookTest plugin is not used', () => { | ||||||
| const config = ` | ||||||
| import { defineConfig } from 'vitest/config'; | ||||||
|
|
||||||
| export default defineConfig({ | ||||||
| test: { | ||||||
| projects: [ | ||||||
| { | ||||||
| extends: true, | ||||||
| test: { | ||||||
| setupFiles: ['./.storybook/vitest.setup.ts'], | ||||||
| }, | ||||||
| }, | ||||||
| ], | ||||||
| }, | ||||||
| }); | ||||||
| `; | ||||||
|
|
||||||
| expect(isConfigAlreadySetup('/project/vitest.config.ts', config)).toBe(false); | ||||||
| }); | ||||||
| }); | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
In eslint-plugin-import-x (or eslint-plugin-import equivalent), does thenamedrule catch invalid named imports that TypeScript may miss (especially when importing from untyped JS/CJS modules)? Please provide current docs/recommendations.💡 Result:
Yes, the import-x/named rule in eslint-plugin-import-x (and the equivalent import/named in eslint-plugin-import) catches invalid named imports from untyped JS/CJS modules that TypeScript may miss. The rule statically analyzes the targeted module file to verify that named imports match actual named exports declared there, regardless of TypeScript typing. Key points from official docs: - It verifies "named imports are part of the set of named exports in the referenced module" by inspecting the file contents {1, high}. - For untyped JS/CJS modules (especially node_modules), it checks package.json for jsnext:main (deprecated) or module fields to find the ES module entry, then analyzes exports {1, high}. - Modules can be ignored via import-x/ignore setting (defaults include node_modules), but when not ignored, it analyzes them {1, high}. - Note: "A module path that is ignored or not unambiguously an ES module will not be reported" {1, high}. CJS modules with module.exports may not be treated as ES modules, potentially skipping analysis, but pure JS ES modules or those with module field are checked. - In TypeScript configs (flat/typescript, typescript), the rule is disabled (🚫) because TypeScript handles named import validation via types, but it can be manually enabled and works with eslint-import-resolver-typescript for path resolution {1,3,4,5, high}. TypeScript itself may miss runtime exports in untyped JS if no .d.ts declares them exhaustively. Current recommendations (2026): - Use eslint-plugin-import-x with flat/recommended or recommended configs where named is enabled by default {3,4,5, high}. - For TS projects, extend plugin:import-x/typescript + resolver, but enable import-x/named explicitly if you want checks on untyped JS {4,16, high}. - Pair with eslint-import-resolver-typescript to properly resolve paths and prefer
@typesbut fall back to JS analysis {16, high}.Citations:
🏁 Script executed:
Repository: storybookjs/storybook
Length of output: 1433
🏁 Script executed:
rg -A 5 -B 5 "import-x/named" code/.eslintrc.jsRepository: storybookjs/storybook
Length of output: 413
🏁 Script executed:
Repository: storybookjs/storybook
Length of output: 156
🏁 Script executed:
Repository: storybookjs/storybook
Length of output: 379
🏁 Script executed:
sed -n '16,68p' code/.eslintrc.jsRepository: storybookjs/storybook
Length of output: 2247
Clarify the misleading comment about JS file configuration
Lines 163–164: The comment states "It IS set to 'error' for JS files," but this ESLint config has no explicit
import-x/namedrule for JS files. The rule is only mentioned here, where it's disabled for TypeScript files. Revise the comment to accurately reflect what the config does—disable the check for TypeScript (where TypeScript validates named imports) while relying on plugin defaults for JS files.🤖 Prompt for AI Agents