Skip to content

Vue3: Clear stale args/globals when nextArgs is empty in updateArgs #34409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sidnioulz merged 4 commits into from
Apr 13, 2026
Merged

Vue3: Clear stale args/globals when nextArgs is empty in updateArgs #34409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c82a732
fix(vue3): clear stale args/globals when nextArgs is empty in updateArgs
whdjh Mar 31, 2026
05516a8
Merge branch 'next' into fix/vue3-clear-stale-reactive-args
Sidnioulz Mar 31, 2026
926d0a5
test(vue3): add e2e test for forced globals cleanup on story navigation
whdjh Apr 7, 2026
e6b71ab
chore: remove e2e test that doesn't reproduce the updateArgs bug
whdjh Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions code/renderers/vue3/src/render.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ describe('Render Story', () => {
expect(reactiveArgs).toEqual({ objectArg: { argFoo: 'bar' } });
});

it('clears all args when nextArgs is empty -> updateArgs()', () => {
const reactiveArgs = reactive({ argFoo: 'foo', argBar: 'bar' });
updateArgs(reactiveArgs, {} as any);
expect(reactiveArgs).toEqual({});
});

it('update reactive Globals', async () => {
const reactiveGlobals = reactive<Globals>({ theme: 'light', locale: 'en' });

Expand Down
3 changes: 0 additions & 3 deletions code/renderers/vue3/src/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,6 @@ export function updateArgs<
[name: string]: unknown;
},
>(reactiveArgs: T, nextArgs: T) {
if (Object.keys(nextArgs).length === 0) {
return;
}
const currentArgs = isReactive(reactiveArgs) ? reactiveArgs : reactive(reactiveArgs);
// delete all args in currentArgs that are not in nextArgs
Object.keys(currentArgs).forEach((key) => {
Expand Down
Loading