Build: Don't format MDX files in monorepo#34397
Conversation
|
View your CI Pipeline Execution ↗ for commit 7ed94b5
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Pull request overview
Stops VS Code from auto-formatting MDX files in this repo’s workspace settings, preventing accidental formatting changes while editing docs.
Changes:
- Adds a VS Code language-specific override to disable
editor.formatOnSavefor MDX files.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a VS Code editor settings override for MDX files to disable automatic formatting on save, while preserving all other existing formatting behaviors controlled by global settings. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Comment |
What I did
Puts an end to accidental formats of MDX content. Can be revisited later. You'll feel the need for this after editing the docs :)
Checklist for Contributors
Testing
ø
Manual testing
Edit MDX file in VSCode. Save. Notice no reformatting.
Documentation
ø
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit