Skip to content

Build: Don't format MDX files in monorepo#34397

Merged
Sidnioulz merged 1 commit into
nextfrom
sidnioulz/dont-format-mdx
Apr 1, 2026
Merged

Build: Don't format MDX files in monorepo#34397
Sidnioulz merged 1 commit into
nextfrom
sidnioulz/dont-format-mdx

Conversation

@Sidnioulz
Copy link
Copy Markdown
Contributor

@Sidnioulz Sidnioulz commented Mar 30, 2026

What I did

Puts an end to accidental formats of MDX content. Can be revisited later. You'll feel the need for this after editing the docs :)

Checklist for Contributors

Testing

ø

Manual testing

Edit MDX file in VSCode. Save. Notice no reformatting.

Documentation

ø

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated development environment configuration to adjust formatting behavior for MDX files.

@Sidnioulz Sidnioulz requested a review from huang-julien March 30, 2026 10:11
Copilot AI review requested due to automatic review settings March 30, 2026 10:11
@Sidnioulz Sidnioulz added build Internal-facing build tooling & test updates ci:normal labels Mar 30, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 30, 2026

View your CI Pipeline Execution ↗ for commit 7ed94b5

Command Status Duration Result
nx run-many -t compile,check,knip,test,lint,fmt... ✅ Succeeded 5m 23s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-30 10:18:40 UTC

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Stops VS Code from auto-formatting MDX files in this repo’s workspace settings, preventing accidental formatting changes while editing docs.

Changes:

  • Adds a VS Code language-specific override to disable editor.formatOnSave for MDX files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 61ea8428-885d-4d96-b366-e4c44f5fe5f2

📥 Commits

Reviewing files that changed from the base of the PR and between 039eb6c and 7ed94b5.

📒 Files selected for processing (1)
  • .vscode/settings.json

📝 Walkthrough

Walkthrough

Added a VS Code editor settings override for MDX files to disable automatic formatting on save, while preserving all other existing formatting behaviors controlled by global settings.

Changes

Cohort / File(s) Summary
VS Code Settings
.vscode/settings.json
Added language-specific editor setting to disable formatOnSave for MDX files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

@huang-julien huang-julien requested a review from kylegach March 31, 2026 08:27
@Sidnioulz Sidnioulz merged commit a4a2449 into next Apr 1, 2026
130 of 139 checks passed
@Sidnioulz Sidnioulz deleted the sidnioulz/dont-format-mdx branch April 1, 2026 12:52
@github-actions github-actions Bot mentioned this pull request Apr 1, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants