Fix docs Meta resolution for split CSF4 story chunks#34375
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughEnhanced DocsContext module resolution to support namespace objects lacking default exports. Added conditional mapping for default exports, implemented fallback logic to infer CSF files by scanning object values and matching stories, and expanded test coverage accordingly. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @raashish1601 , Due to a recent high volume of unreviewed AI-generated PRs, we are requesting verification and proof that the implemented fix actually works. Please provide a simple GIF/Video or image of how the bugfix works, optimally with before-and-after comparisons. Thank you for your understanding! |
|
Hi @raashish1601, We requested verification that this PR works as intended, but haven't received a response in over two weeks. We're closing this PR for now. If you'd like to continue working on this, feel free to reopen the PR with the requested verification (a GIF/video or screenshot showing before-and-after behavior). Thank you for your contribution! |
Fixes #34373.
Summary
<Meta of={Stories} />receives a split namespace object without a default export<Meta of={...} />strict by refusing mixed namespaces whose story exports resolve to different CSF filesTesting
corepack yarn --cwd code build storybook --no-watch --no-prodcorepack yarn --cwd code vitest run --config core/vitest.config.ts core/src/preview-api/modules/preview-web/docs-context/DocsContext.test.ts core/src/preview-api/modules/preview-web/render/MdxDocsRender.test.tsSummary by CodeRabbit
Bug Fixes
Tests