Core: Add ChangeDetectionService and wire up builder-vite#34369
Merged
Conversation
Track changed files from git, trace affected story files through the builder module graph, and surface those results through the dev server status store.
ghengeveld
changed the title
ChangeDetectionService and wire up builder-vite
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a server-side change detection pipeline that uses the builder’s module graph plus git working tree changes to compute per-story “new/modified/affected” statuses and publish them via the dev server status store.
Changes:
- Add
ChangeDetectionService(+ readiness signal) and supporting git diff + module-graph tracing utilities incore-server. - Wire the service into
storybookDevServer()and export the experimental readiness API. - Update
@storybook/builder-viteto warm up/poll the module graph and emit graph changes for consumers.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| code/core/src/types/modules/core-common.ts | Formatting adjustment for type-only imports. |
| code/core/src/core-server/index.ts | Export change detection readiness + service from core-server. |
| code/core/src/core-server/dev-server.ts | Instantiate/start change detection service and dispose on preview build failure. |
| code/core/src/core-server/change-detection/trace-changed.ts | BFS tracer from changed file → reachable story files with distances. |
| code/core/src/core-server/change-detection/trace-changed.test.ts | Unit tests for BFS tracer behavior (distance, cycles, etc.). |
| code/core/src/core-server/change-detection/service.ts | Core service: git diff + module-graph tracing + status store patching + readiness. |
| code/core/src/core-server/change-detection/service.test.ts | Unit tests for service status classification and patch behavior. |
| code/core/src/core-server/change-detection/readiness.ts | Deferred readiness signal implementation. |
| code/core/src/core-server/change-detection/index.ts | Barrel exports for change detection module. |
| code/core/src/core-server/change-detection/git-diff-provider.ts | git CLI provider for staged/unstaged/untracked file detection. |
| code/core/src/core-server/change-detection/git-diff-provider.test.ts | Unit tests for git diff provider. |
| code/core/src/core-server/change-detection/errors.ts | Typed error classes for unavailable/failure conditions. |
| code/builders/builder-vite/src/index.ts | Add module-graph warmup/polling to reliably emit module graph changes. |
| code/builders/builder-vite/src/index.test.ts | Update tests to account for new warmup/polling behavior and watcher hookup timing. |
| .vscode/settings.json | Point VS Code TS SDK to node_modules/typescript. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughIntroduces a change-detection subsystem that observes Vite module-graph updates, runs git-based diffs, computes per-story impact (new/modified/affected) via dependency traversal, publishes statuses to a status store, and exposes readiness/error states for consumers. Changes
Sequence DiagramsequenceDiagram
participant DevServer as Dev Server
participant Builder as Vite Builder
participant ModuleGraph as Module Graph
participant GitProvider as GitDiffProvider
participant Service as ChangeDetectionService
participant StatusStore as Status Store
DevServer->>Service: construct(start with storyIndexGenerator, statusStore)
DevServer->>Builder: start and register onModuleGraphChange
Builder->>ModuleGraph: module graph updates
Builder->>Service: emit {type:'moduleGraph', moduleGraph}
Service->>Service: debounce / schedule scan
Service->>GitProvider: getChangedFiles()
GitProvider->>GitProvider: run git commands
GitProvider-->>Service: return {changed, new}
Service->>Service: findAffectedStoryFiles(changed, moduleGraph)
Service->>Service: compute per-story statuses (new/modified/affected)
Service->>StatusStore: applyPatch(statuses)
Service->>Service: setChangeDetectionReadiness('ready')
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
code/core/src/core-server/change-detection/git-diff-provider.ts (1)
43-72: Consider more specific error attribution for parallel git commands.When the
Promise.allrejects, the error is attributed to'git diff'(line 70), but the failure could originate from any of the three commands includinggit ls-files. This could make debugging slightly harder.Consider capturing command context or using
Promise.allSettledwith individual error handling if precise attribution is needed, though this is a minor concern since all commands run in the same repo context.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@code/core/src/core-server/change-detection/git-diff-provider.ts` around lines 43 - 72, The Promise.all in getChangedFiles currently maps any rejection to a generic 'git diff' error via toGitError, which loses which of the three execa calls failed; update getChangedFiles to attribute errors to the specific command that failed (e.g., the first execa for staged diff, second for unstaged diff, or the execa('git', ['ls-files'...]) for untracked) by either using Promise.allSettled and checking each result for .status === 'rejected' and calling toGitError with a descriptive command name, or by wrapping each execa call in its own try/catch that calls this.toGitError(error, '<specific git command>') before rethrowing so the thrown error contains the precise command context.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@code/builders/builder-vite/src/index.ts`:
- Around line 121-122: The fire-and-forget call to startChangeDetection(options)
can reject during preset resolution/index generation/warmup and leave change
detection half-initialized; make this explicit and observe rejections by calling
it as void startChangeDetection(options).catch(err => { /* handle/log */ });:
update the call site to prefix with void and attach a .catch that logs the error
(use the existing logger in this module or console.error) and perform any
minimal cleanup or state marking so bail() or shutdown sees the failure,
referencing startChangeDetection and bail to ensure the cleanup path remains
correct.
- Around line 88-98: The code in waitForModuleGraph registers and calls
watcherChangeHandler after awaiting server.waitForRequestsIdle(), but bail() may
clear watcherChangeHandler during that await causing server.watcher.on('all',
watcherChangeHandler) or watcherChangeHandler() to be invoked as undefined;
update the block in waitForModuleGraph to re-check that watcherChangeHandler is
still defined after the await (i.e., after server.waitForRequestsIdle()) before
calling server.watcher.on('all', watcherChangeHandler) and before invoking
watcherChangeHandler(), and bail() should continue to be allowed to clear
watcherChangeHandler as before.
In `@code/core/src/core-server/change-detection/git-diff-provider.test.ts`:
- Around line 20-38: Move the vi.mocked(execa) setup into a beforeEach and split
the "staged-new" and "untracked-new" fixtures so the same path isn't returned by
both staged and untracked commands; specifically, in beforeEach mock the
sequence of execa calls that GitDiffProvider('/repo') expects (repo root, staged
list, unstaged list, untracked list) and ensure the staged list contains the
"new" file (e.g. 'src/NewButton.stories.tsx') while the untracked list contains
a different file (e.g. 'src/Button.css'), then remove any inline
vi.mocked(execa) calls from individual it blocks so tests call
GitDiffProvider.getChangedFiles() against the shared beforeEach mocks.
---
Nitpick comments:
In `@code/core/src/core-server/change-detection/git-diff-provider.ts`:
- Around line 43-72: The Promise.all in getChangedFiles currently maps any
rejection to a generic 'git diff' error via toGitError, which loses which of the
three execa calls failed; update getChangedFiles to attribute errors to the
specific command that failed (e.g., the first execa for staged diff, second for
unstaged diff, or the execa('git', ['ls-files'...]) for untracked) by either
using Promise.allSettled and checking each result for .status === 'rejected' and
calling toGitError with a descriptive command name, or by wrapping each execa
call in its own try/catch that calls this.toGitError(error, '<specific git
command>') before rethrowing so the thrown error contains the precise command
context.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cfc75601-eb26-4b8f-8040-78cbf224f12c
📒 Files selected for processing (15)
.vscode/settings.jsoncode/builders/builder-vite/src/index.test.tscode/builders/builder-vite/src/index.tscode/core/src/core-server/change-detection/errors.tscode/core/src/core-server/change-detection/git-diff-provider.test.tscode/core/src/core-server/change-detection/git-diff-provider.tscode/core/src/core-server/change-detection/index.tscode/core/src/core-server/change-detection/readiness.tscode/core/src/core-server/change-detection/service.test.tscode/core/src/core-server/change-detection/service.tscode/core/src/core-server/change-detection/trace-changed.test.tscode/core/src/core-server/change-detection/trace-changed.tscode/core/src/core-server/dev-server.tscode/core/src/core-server/index.tscode/core/src/types/modules/core-common.ts
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@code/core/src/core-server/change-detection/service.ts`:
- Around line 123-131: The dispose() method currently only prevents future
callbacks but doesn't stop already-running scan() tasks from calling
applyPatch() / setChangeDetectionReadiness() or scheduling another run; add a
disposed boolean field (e.g., this.disposed = false initially), set
this.disposed = true in dispose() (alongside clearing debounceTimer and
unsubscribe), and update scan() to check this.disposed after any await points
(notably after awaiting buildStatuses(...) and before calling applyPatch() /
setChangeDetectionReadiness() and before triggering the finally rerun logic) so
that no state changes or reruns occur once disposed.
- Line 1: The code currently uses resolve() and a string replace to strip
repoRoot from absolute file paths (affecting changedStoryFiles), which fails on
Windows due to backslashes; import and use path.relative() instead: compute
repoRelative = relative(repoRoot, absPath) for each path (in the same place
where changedStoryFiles are built), and if you need consistent separators,
normalize to forward slashes (e.g., replace backslashes) before adding to
changedStoryFiles; update the import to include relative from 'node:path' and
remove the fragile `${repoRoot}/` string-replacement logic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 823b50be-6b9f-4665-ba77-919e4df564db
📒 Files selected for processing (6)
code/.storybook/main.tscode/builders/builder-vite/src/index.test.tscode/core/src/core-server/change-detection/index.tscode/core/src/core-server/change-detection/service.tscode/core/src/shared/status-store/index.tscode/core/src/types/modules/status.ts
✅ Files skipped from review due to trivial changes (3)
- code/.storybook/main.ts
- code/core/src/shared/status-store/index.ts
- code/core/src/core-server/change-detection/index.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- code/builders/builder-vite/src/index.test.ts
…s for changed files and update related tests. Adjusted logic to handle new and changed files more effectively.
|
View your CI Pipeline Execution ↗ for commit 1110110
☁️ Nx Cloud last updated this comment at |
…dule graph subscription. Introduced ViteModuleGraphSubscriptionError for better error messaging. Updated tests to cover new scenarios and ensure robust change detection functionality. Handled review comments.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
code/builders/builder-vite/src/index.ts (1)
96-99: Warm each import path once.
storyIndex.entriesis entry-level, so the same CSF file can show up once per story (plus docs entries). DedupingimportPathvalues keeps startup work proportional to files instead of entries.Proposed refactor
- await Promise.all( - Object.values(storyIndex.entries).map((entry) => server.warmupRequest(entry.importPath)) - ); + const importPaths = new Set( + Object.values(storyIndex.entries).map((entry) => entry.importPath) + ); + + await Promise.all( + Array.from(importPaths, (importPath) => server.warmupRequest(importPath)) + );🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@code/builders/builder-vite/src/index.ts` around lines 96 - 99, The current warm-up calls loop over storyIndex.entries and calls server.warmupRequest(entry.importPath) for every entry, which duplicates work for multiple stories from the same CSF file; change this to dedupe by importPath first (e.g., collect unique entry.importPath values from storyIndex.entries) and then call server.warmupRequest once per unique importPath so server.warmupRequest and storyIndex.entries remain the referenced symbols to locate the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@code/builders/builder-vite/src/index.ts`:
- Around line 102-123: The polling block around waitForModuleGraph currently
swallows startup timeout/failure; on both the >30s branch and the catch branch
you must surface a terminal failure to ChangeDetectionService so start() can
settle instead of waiting forever. Modify the timeout branch (where
process.hrtime(startTime)[0] > 30) and the catch block to call the
change-detection readiness/failure API (e.g., invoke the ChangeDetectionService
method that marks startup as unavailable/fails readiness or emit its
"unavailable"/error event) rather than only calling clearModuleGraphPolling and
logging; ensure you reference the same
watcherChangeHandler/server.waitForRequestsIdle flow so you still attach the
watcher when successful, but on any warmup/getIndex/waitForRequestsIdle failure
or timeout call the ChangeDetectionService failure signal (or reject its startup
promise) so consumers waiting on start() or the first scan are unblocked with an
error.
In `@code/core/src/core-server/change-detection/service.ts`:
- Around line 189-195: When handling ChangeDetectionUnavailableError in the scan
branch, after calling this.resolveReadiness({ status: 'unavailable', reason:
error.message, error }), immediately invoke the teardown helper that cancels the
scanner/subscription (the teardown function defined earlier near the readiness
setup) so the service unsubscribes/stops scanning and does not re-run git on
subsequent module-graph updates; keep the resolveReadiness call and add the
teardown invocation right after it in the ChangeDetectionUnavailableError
branch.
---
Nitpick comments:
In `@code/builders/builder-vite/src/index.ts`:
- Around line 96-99: The current warm-up calls loop over storyIndex.entries and
calls server.warmupRequest(entry.importPath) for every entry, which duplicates
work for multiple stories from the same CSF file; change this to dedupe by
importPath first (e.g., collect unique entry.importPath values from
storyIndex.entries) and then call server.warmupRequest once per unique
importPath so server.warmupRequest and storyIndex.entries remain the referenced
symbols to locate the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9823a29d-9838-4d0b-b8d9-eae15711f080
📒 Files selected for processing (8)
code/builders/builder-vite/src/index.test.tscode/builders/builder-vite/src/index.tscode/core/src/core-server/change-detection/git-diff-provider.test.tscode/core/src/core-server/change-detection/git-diff-provider.tscode/core/src/core-server/change-detection/service.test.tscode/core/src/core-server/change-detection/service.tscode/core/src/core-server/change-detection/trace-changed.tscode/core/src/server-errors.ts
🚧 Files skipped from review as they are similar to previous changes (5)
- code/core/src/core-server/change-detection/trace-changed.ts
- code/core/src/core-server/change-detection/git-diff-provider.test.ts
- code/core/src/core-server/change-detection/git-diff-provider.ts
- code/builders/builder-vite/src/index.test.ts
- code/core/src/core-server/change-detection/service.test.ts
valentinpalkovic
approved these changes
Mar 30, 2026
Surface Vite module-graph startup failures and timeouts to ChangeDetectionService so readiness no longer hangs. Stop rescanning after permanent unavailability, dedupe warmup requests by import path, and harden preview cleanup error handling.
ghengeveld
force-pushed
the
change-detection-service
branch
from
baa4179 to
a572bf6
Compare
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 50 | 50 | 0 |
| Self size | 20.47 MB | 20.49 MB | 🚨 +18 KB 🚨 |
| Dependency size | 16.55 MB | 16.55 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 184 | 184 | 0 |
| Self size | 782 KB | 782 KB | 🎉 -84 B 🎉 |
| Dependency size | 67.70 MB | 67.72 MB | 🚨 +18 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 177 | 177 | 0 |
| Self size | 32 KB | 32 KB | 0 B |
| Dependency size | 66.22 MB | 66.24 MB | 🚨 +18 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 51 | 51 | 0 |
| Self size | 1.04 MB | 1.04 MB | 🎉 -72 B 🎉 |
| Dependency size | 37.03 MB | 37.05 MB | 🚨 +18 KB 🚨 |
| Bundle Size Analyzer | node | node |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (4)
code/core/src/core-server/change-detection/service.test.ts (2)
93-99: Stublogger.debughere as well.
ChangeDetectionService.start()hitslogger.debug()on the enabled/disabled path, so this setup still exercises a real logger method in most tests.Patch
vi.mocked(logger.info).mockImplementation(() => undefined); vi.mocked(logger.warn).mockImplementation(() => undefined); vi.mocked(logger.error).mockImplementation(() => undefined); + vi.mocked(logger.debug).mockImplementation(() => undefined);As per coding guidelines, "Mock external dependencies like file system access and loggers in tests" and "Mock all required properties and methods that the test subject uses in Vitest tests."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@code/core/src/core-server/change-detection/service.test.ts` around lines 93 - 99, The tests call ChangeDetectionService.start() which triggers logger.debug on the enabled/disabled path but the beforeEach only stubs logger.info/warn/error; add a mock for logger.debug in the beforeEach (alongside the existing vi.mocked(logger.info/warn/error).mockImplementation(...) calls and before internal_resetChangeDetectionReadiness()) so the real logger.debug is not exercised during tests; reference the beforeEach setup and the logger.debug symbol when making the change.
532-588: Add a slash-normalized module-graph case here.This only exercises
join()/native-separator inputs, whilecode/builders/builder-vite/src/index.test.tsmodels module-graph entries with slash paths. AC:/repo/...case would pin down that integration boundary and catch separator mismatches earlier.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@code/core/src/core-server/change-detection/service.test.ts` around lines 532 - 588, Add a second test variant (or extend the existing 'stores changed files as normalized repo-relative paths' test) that constructs the ModuleGraph using forward-slash (POSIX) path strings instead of path.join/native separators and then emits that graph to ChangeDetectionService; specifically, create a slash-normalized moduleGraph key (e.g. build a string for the module id by taking workingDir and replacing platform separators with '/' and appending '/src/Button.module.css'), use that string as the Map key in moduleGraph and ensure gitDiffProvider.getChangedFiles still returns a repo-relative 'src/Button.module.css' entry, call service.start(...) and emit(theSlashNormalizedModuleGraph) and assert the same status output from getStatusStoreByTypeId(CHANGE_DETECTION_STATUS_TYPE_ID). This ensures ChangeDetectionService normalization logic (used during emit and in methods like start/emit handling) handles slash-separated module graph entries.code/builders/builder-vite/src/index.test.ts (2)
305-310: Assert the exported error type too.This still passes if
onModuleGraphChange()starts throwing a genericErrorwith the same message. Tightening it toViteModuleGraphSubscriptionErrorfromcode/core/src/server-errors.tswould keep the public contract covered.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@code/builders/builder-vite/src/index.test.ts` around lines 305 - 310, Update the test to assert the specific exported error class instead of only the message: import ViteModuleGraphSubscriptionError from code/core/src/server-errors.ts and replace the current expect(() => onModuleGraphChange(vi.fn())).toThrow('...') with an assertion that the call throws that class (e.g., expect(() => onModuleGraphChange(vi.fn())).toThrowError(ViteModuleGraphSubscriptionError) or the framework's equivalent to assert instance-of), keeping the original message check if desired.
267-280: Clearcbbefore the restart assertion.The other listener tests reset the spy right after
startChangeDetection(). Doing the same here keeps Line 280 about the post-bail()restart only, instead of any startup notification the helper may emit.Patch
await startChangeDetection(); + cb.mockClear(); expect(fakeViteServer.watcher.listenerCount('all')).toBe(1);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@code/builders/builder-vite/src/index.test.ts` around lines 267 - 280, Reset the spy so the post-restart assertion only checks restart-triggered calls: after calling startChangeDetection() (and after the first expect on fakeViteServer.watcher.listenerCount('all')), call cb.mockClear() so any startup notifications are cleared before calling bail(), start(createStartArgs(['/src/Button.tsx'])) and advancing timers; this ensures the later fakeViteServer.watcher.emit('change', '/src/Button.tsx') and expect(cb).not.toHaveBeenCalled() only reflect restart behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@code/builders/builder-vite/src/index.test.ts`:
- Around line 305-310: Update the test to assert the specific exported error
class instead of only the message: import ViteModuleGraphSubscriptionError from
code/core/src/server-errors.ts and replace the current expect(() =>
onModuleGraphChange(vi.fn())).toThrow('...') with an assertion that the call
throws that class (e.g., expect(() =>
onModuleGraphChange(vi.fn())).toThrowError(ViteModuleGraphSubscriptionError) or
the framework's equivalent to assert instance-of), keeping the original message
check if desired.
- Around line 267-280: Reset the spy so the post-restart assertion only checks
restart-triggered calls: after calling startChangeDetection() (and after the
first expect on fakeViteServer.watcher.listenerCount('all')), call
cb.mockClear() so any startup notifications are cleared before calling bail(),
start(createStartArgs(['/src/Button.tsx'])) and advancing timers; this ensures
the later fakeViteServer.watcher.emit('change', '/src/Button.tsx') and
expect(cb).not.toHaveBeenCalled() only reflect restart behavior.
In `@code/core/src/core-server/change-detection/service.test.ts`:
- Around line 93-99: The tests call ChangeDetectionService.start() which
triggers logger.debug on the enabled/disabled path but the beforeEach only stubs
logger.info/warn/error; add a mock for logger.debug in the beforeEach (alongside
the existing vi.mocked(logger.info/warn/error).mockImplementation(...) calls and
before internal_resetChangeDetectionReadiness()) so the real logger.debug is not
exercised during tests; reference the beforeEach setup and the logger.debug
symbol when making the change.
- Around line 532-588: Add a second test variant (or extend the existing 'stores
changed files as normalized repo-relative paths' test) that constructs the
ModuleGraph using forward-slash (POSIX) path strings instead of path.join/native
separators and then emits that graph to ChangeDetectionService; specifically,
create a slash-normalized moduleGraph key (e.g. build a string for the module id
by taking workingDir and replacing platform separators with '/' and appending
'/src/Button.module.css'), use that string as the Map key in moduleGraph and
ensure gitDiffProvider.getChangedFiles still returns a repo-relative
'src/Button.module.css' entry, call service.start(...) and
emit(theSlashNormalizedModuleGraph) and assert the same status output from
getStatusStoreByTypeId(CHANGE_DETECTION_STATUS_TYPE_ID). This ensures
ChangeDetectionService normalization logic (used during emit and in methods like
start/emit handling) handles slash-separated module graph entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4c0f5b41-aacb-4f0e-968d-66bd93a0723f
📒 Files selected for processing (7)
code/builders/builder-vite/src/index.test.tscode/builders/builder-vite/src/index.tscode/core/src/core-server/change-detection/service.test.tscode/core/src/core-server/change-detection/service.tscode/core/src/core-server/dev-server.tscode/core/src/manager/globals/exports.tscode/core/src/types/modules/core-common.ts
✅ Files skipped from review due to trivial changes (1)
- code/core/src/manager/globals/exports.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- code/core/src/core-server/dev-server.ts
- code/core/src/types/modules/core-common.ts
- code/builders/builder-vite/src/index.ts
9 tasks
This was referenced Apr 29, 2026
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34253
What I did
Implement module-graph change detection for affected stories.
Track changed files from git, trace affected story files through the builder module graph, and surface those results through the dev server status store.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-34369-sha-7d187a58. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-34369-sha-7d187a58 sandboxor in an existing project withnpx storybook@0.0.0-pr-34369-sha-7d187a58 upgrade.More information
0.0.0-pr-34369-sha-7d187a58change-detection-service7d187a581774878150)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=34369Summary by CodeRabbit