Cleanup: Add back fmt:check into nx#34306
Conversation
|
View your CI Pipeline Execution ↗ for commit a817cb9
☁️ Nx Cloud last updated this comment at |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a new Nx Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@code/project.json`:
- Around line 6-12: The fmt target in project.json runs "yarn fmt:check" but its
inputs only include "default", risking cache staleness; either expand the
"inputs" to include workspace-wide files that the formatter touches or restrict
the command to the project directory by adding a "cwd": "{projectRoot}" option
to the fmt target (matching the lint target pattern). Locate the "fmt" target
entry and update its "inputs" to cover the workspace files used by oxfmt (e.g.,
add shared/workspace inputs) or add the "cwd": "{projectRoot}" key alongside
"options" so the yarn fmt:check command only checks the projectRoot, then run
the formatter check to verify caching behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cde1cb46-9d0c-46d1-bcc3-0582b177d2b6
📒 Files selected for processing (2)
.github/workflows/nx.ymlcode/project.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Build: Add back fmt:check into nx (cherry picked from commit a8048f5)
Closes #
What I did
Did a small mistake in the former oxfmt PR. We remove fmt:check from
yarn lintbut forgot to add it back into nx.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit